Consolidate identical ELF auxargs type defintions.
ClosedPublic
Actions

Authored by brooks on Oct 3 2018, 11:27 PM.

Details

Reviewers

emaste
jhb
andrew
manu
imp
jhibbits

Commits

rS339625: Consolidate identical ELF auxargs type defintions.

Summary

All platforms except powerpc use the same values and powerpc shares a majority of them.

Go ahead and declare AT_NOTELF, AT_UID, and AT_EUID in favor of the unused AT_DCACHEBSIZE, AT_ICACHEBSIZE, and AT_UCACHEBSIZE for powerpc as the supposed conflict doesn't matter

Test Plan

universe build

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19982
Build 19489: arc lint + arc unit

Event Timeline

brooks created this revision.Oct 3 2018, 11:27 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 3 2018, 11:27 PM

Harbormaster completed remote builds in B19945: Diff 48700.Oct 3 2018, 11:27 PM

Actually, my plan is to just change them on powerpc and have them unified across the board. They should then really just live in sys/elf_common.h. I think if we want to move them now we should just move them and maybe add some #ifdef powerpc that we eventually remove when renumbering powerpc's vectors. I think the actual renumbering change is probably too big of a change during code freeze.

Move all of AT_* to sys/elf_common.h with powerpc ifdefs.

Herald added a subscriber: jhibbits. · View Herald TranscriptOct 4 2018, 8:26 PM

Harbormaster completed remote builds in B19982: Diff 48750.Oct 4 2018, 8:26 PM

brooks edited the summary of this revision. (Show Details)Oct 4 2018, 8:27 PM

brooks edited the summary of this revision. (Show Details)Oct 4 2018, 8:33 PM

jhb accepted this revision.Oct 4 2018, 9:08 PM

This revision is now accepted and ready to land.Oct 4 2018, 9:08 PM

Universe builds except for the perennially broken riscv64sf. Tested amd64 with new and old user land and kernel in all parings (new, old; old, new; new, new).