Page MenuHomeFreeBSD
Differential D16962

ddb: Enable 'thread <address>'
ClosedPublic
Actions

Authored by cem on Aug 30 2018, 10:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 10:05 PM
Unknown Object (File)
Sat, Jan 18, 5:07 PM
Unknown Object (File)
Sun, Jan 12, 5:40 PM
Unknown Object (File)
Thu, Jan 9, 8:10 PM
Unknown Object (File)
Dec 17 2024, 8:54 AM
Unknown Object (File)
Dec 7 2024, 4:34 AM
Unknown Object (File)
Nov 21 2024, 3:21 PM
Unknown Object (File)
Oct 10 2024, 10:25 AM
View All 69 Files
Subscribers
imp

Details

Reviewers
markj
kib
bwidawsk
bdrewery
jhb
Group Reviewers
manpages
Commits
rS339486: ddb: Enable 'thread <address>'
Summary

Prior to this change, the 'thread' command (to switch the debugger to another
thread) only accepts decimal-encoded tids. This is a minor nuisance and
sometimes stumbling block.

Use the same parsing logic as 'show thread <arg>' to enable 'thread' to accept
hex-encoded thread pointers in addition to decimal-encoded tids.

Test Plan

Untested other than compile. Will confirm before committing.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19337
Build 18942: arc lint + arc unit

Event Timeline

cem created this revision.Aug 30 2018, 10:56 PM
Harbormaster completed remote builds in B19300: Diff 47502.Aug 30 2018, 10:56 PM
kib accepted this revision.Aug 31 2018, 7:59 AM
This revision is now accepted and ready to land.Aug 31 2018, 7:59 AM
markj added a comment.Aug 31 2018, 12:05 PM

Does ddb.4 need to be updated?

bwidawsk accepted this revision.Aug 31 2018, 5:45 PM

I think man page does need to be updated as markj said.

cem updated this revision to Diff 47553.Sep 1 2018, 4:19 AM

Document 'thread' (entirely absent) and 'show thread' tid behavior.

This revision now requires review to proceed.Sep 1 2018, 4:19 AM
Harbormaster completed remote builds in B19337: Diff 47553.Sep 1 2018, 4:19 AM
markj accepted this revision.Sep 1 2018, 5:12 AM
This revision is now accepted and ready to land.Sep 1 2018, 5:12 AM
Closed by commit rS339486: ddb: Enable 'thread <address>' (authored by cem). · Explain WhyOct 20 2018, 8:46 PM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: manpages. · View Herald TranscriptOct 20 2018, 8:46 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
share/
man/
man4/
21 lines
sys/
ddb/
2 lines
12 lines

Diff 47553

View Options

share/man/man4/ddb.4

Loading...
View Options

sys/ddb/db_command.c

Loading...
View Options

sys/ddb/db_thread.c

Loading...