Page MenuHomeFreeBSD
Differential D16923

Document cpu_microcode_* in loader.conf.5.
ClosedPublic
Actions

Authored by markj on Aug 27 2018, 7:00 PM.
Tags
None
Referenced Files
F168164617: D16923.id47357.diff
Wed, Aug 26, 4:27 PM
F168108343: D16923.diff
Wed, Aug 26, 10:33 AM
F168044442: D16923.id47391.diff
Wed, Aug 26, 2:51 AM
F168044358: D16923.id47357.diff
Wed, Aug 26, 2:51 AM
Unknown Object (File)
Tue, Aug 25, 8:40 PM
Unknown Object (File)
Tue, Aug 25, 12:30 PM
Unknown Object (File)
Mon, Aug 24, 2:08 AM
Unknown Object (File)
Sat, Aug 15, 12:04 PM
View All Files
Subscribers
bcr
imp

Details

Reviewers
emaste
kib
jhb
bcr
Group Reviewers
manpages
Commits
rS338354: Document the cpu_microcode_* tunables.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19225
Build 18838: arc lint + arc unit

Event Timeline

markj created this revision.Aug 27 2018, 7:00 PM
Harbormaster completed remote builds in B19222: Diff 47357.Aug 27 2018, 7:00 PM
markj added reviewers: emaste, kib, jhb, manpages.Aug 27 2018, 7:01 PM
bcr accepted this revision.Aug 27 2018, 7:06 PM
bcr added a subscriber: bcr.

Fine from manpages. Thanks for the work!

This revision is now accepted and ready to land.Aug 27 2018, 7:06 PM
kib added a comment.Aug 27 2018, 7:35 PM

I think it would be useful to cross-reference cpucontrol(8) there. Also, when noting that the update is loaded very early, say that it is persistent over suspend/resume.

markj updated this revision to Diff 47361.Aug 27 2018, 7:45 PM
  • Reference suspend/resume and cpucontrol(8).
This revision now requires review to proceed.Aug 27 2018, 7:45 PM
Harbormaster completed remote builds in B19225: Diff 47361.Aug 27 2018, 7:45 PM
kib added inline comments.Aug 27 2018, 7:56 PM
stand/defaults/loader.conf.5
301

Uh, I thought that it was fixed, no ?

markj added inline comments.Aug 27 2018, 7:59 PM
stand/defaults/loader.conf.5
301

Oh, you're right, that should work now.

markj added inline comments.Aug 27 2018, 8:04 PM
stand/defaults/loader.conf.5
301

... well, it works only for Intel CPUs for now.

markj updated this revision to Diff 47386.Aug 28 2018, 4:37 PM
  • Remove incorrect claim about cpucontrol(8)-based updates.
Harbormaster completed remote builds in B19240: Diff 47386.Aug 28 2018, 4:37 PM
kib accepted this revision.Aug 28 2018, 4:46 PM
This revision is now accepted and ready to land.Aug 28 2018, 4:46 PM
Closed by commit rS338354: Document the cpu_microcode_* tunables. (authored by markj). · Explain WhyAug 28 2018, 5:15 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptAug 28 2018, 5:15 PM

Revision Contents
Changeset List

PathSize
stand/
defaults/
23 lines

Diff 47361

View Options

stand/defaults/loader.conf.5

Loading...