Use arc4rand() instead of read_random()
ClosedPublic
Actions

Authored by tuexen on Aug 23 2018, 7:31 AM.

Details

Reviewers

jmg
jtl
rrs
jason_eggnet.com
gordon
delphij

Group Reviewers

transport
secteam

Commits

rS338273: Use arc4rand() instead of read_random() in the SCTP and TCP code.

Summary

jmg@ has suggested to use arc4rand() instead of read_random() as indicated by the man read_random.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 19084

Event Timeline

tuexen created this revision.Aug 23 2018, 7:31 AM

Herald added a reviewer: transport. · View Herald TranscriptAug 23 2018, 7:31 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B19084: Diff 47153.Aug 23 2018, 7:31 AM

IMO, looks good to me.

Added our SO as well.

Add secteam instead of just me.

LGTM.

It seems that the other read_random instances in network stack should do the same as well (probably beyond scope of this changeset though).

jtl accepted this revision.Aug 23 2018, 6:16 PM

This revision is now accepted and ready to land.Aug 23 2018, 6:16 PM

Closed by commit rS338273: Use arc4rand() instead of read_random() in the SCTP and TCP code. (authored by tuexen). · Explain WhyAug 23 2018, 7:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

sctp_os_bsd.h

2 lines

tcp_subr.c

4 lines

Diff 47153

View Options

sys/netinet/sctp_os_bsd.h