Paths

Table of Contentst

Allow implicit connection setup for TCP/IPv6
ClosedPublic
Actions

Authored by tuexen on Jul 26 2018, 2:52 PM.

Details

Reviewers

pkelsey
kbowling
bz
rrs

Group Reviewers

transport

Commits

rS336940: Allow implicit TCP connection setup for TCP/IPv6.

Summary

TCP/IPv4 allows an implicit connection setup using sendto. This is used for TTCP and TCP fast open. This patch adds support for this also to TCP/IPv6.
While there, improve some tests for detecting multicast addresses , which are mapped.

Test Plan

Use the attached program to test combinations of mapped and non mapped addresses. In addition, run the attached packetdrill scripts.

tcp-sendto-ttcp-ipv4.pkt2 KBDownload

tcp-sendto-fo-ipv6.pkt3 KBDownload

tcp-sendto-fo-ipv4.pkt3 KBDownload

tcp-sendto--ttcp-ipv6.pkt2 KBDownload

tcp_sendto_test.c3 KBDownload

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 18414

Event Timeline

tuexen created this revision.Jul 26 2018, 2:52 PM

Herald added a reviewer: transport. · View Herald TranscriptJul 26 2018, 2:52 PM

Herald added subscribers: ae, imp. · View Herald Transcript

Harbormaster completed remote builds in B18352: Diff 45877.Jul 26 2018, 2:52 PM

tuexen added a reviewer: pkelsey.Jul 26 2018, 2:52 PM

tuexen added a reviewer: kbowling.Jul 29 2018, 9:14 AM

We are appreciative of this work on IP6 robustness.. our use case is local and IP4 currently.

This revision is now accepted and ready to land.Jul 29 2018, 9:16 AM

Looks like there is a couple of overlong lines in there which should be wrapped.
Can you put comments at else and endif parts as the blocks are at times rather long and nested, so it would make it easier to find the other bit?

Please reference the IPv4 version if there was a similar change for that in the commit message.

This revision now requires changes to proceed.Jul 29 2018, 9:38 AM

Try to address issues reported by bz@.

Harbormaster completed remote builds in B18413: Diff 45986.Jul 29 2018, 11:40 AM

@bz: I tried to address the issues brought up by you. Regarding the IPv4 related commit: There was no IPv6 support (which is added by this patch) and there was no real checking for IPv4 (which is added by this patch). There was no real IPv4 related commit bringing in a corresponding feature. The checks where added to the connect code path, but where missed in the sendto code path...

There's an exclamation mark missing at the ##else; like [style(9)]:

#ifdef COMPAT_43
/* A large region here, or other conditional code. */
#else /* !COMPAT_43 */
/* Or here. */
#endif /* COMPAT_43 */

Apart from that, thanks! :) I haven't done a any logical review. I assume Kevin has done that.

This revision is now accepted and ready to land.Jul 29 2018, 11:45 AM

Address final comment from bz@

This revision now requires review to proceed.Jul 29 2018, 12:02 PM

Harbormaster completed remote builds in B18414: Diff 45987.Jul 29 2018, 12:02 PM

rrs accepted this revision.Jul 30 2018, 10:17 AM

This revision is now accepted and ready to land.Jul 30 2018, 10:17 AM

Closed by commit rS336940: Allow implicit TCP connection setup for TCP/IPv6. (authored by tuexen). · Explain WhyJul 30 2018, 9:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_usrreq.c

137 lines

netinet6/

in6_proto.c

2 lines

Diff 45987

View Options

sys/netinet/tcp_usrreq.c