Page MenuHomeFreeBSD
Differential D16147

Create a macro for the static modifier with VNET
ClosedPublic
Actions

Authored by andrew on Jul 5 2018, 6:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 8:16 AM
Unknown Object (File)
Mon, May 13, 7:40 AM
Unknown Object (File)
Mon, May 13, 7:40 AM
Unknown Object (File)
Mon, May 13, 7:40 AM
Unknown Object (File)
Mon, May 13, 5:20 AM
Unknown Object (File)
Mon, May 13, 1:16 AM
Unknown Object (File)
Mar 20 2024, 4:06 PM
Unknown Object (File)
Mar 7 2024, 7:53 PM
View All 37 Files
Subscribers
ae
farrokhi
imp

Details

Reviewers
bz
Group Reviewers
transport
manpages
Commits
rS336676: Use the new VNET_DEFINE_STATIC macro when we are defining static VNET
rS336674: As with DPCPU create VNET_DEFINE_STATIC for when a variable needs to be
Summary

As with DPCPU create a _STATIC version of VNET_DEFINE. This will allow us
to change this on arm64 later and enable VIMAGE.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18202
Build 17934: arc lint + arc unit

Event Timeline

andrew created this revision.Jul 5 2018, 6:48 PM
Herald added a reviewer: transport. · View Herald TranscriptJul 5 2018, 6:48 PM
Herald added subscribers: farrokhi, ae. · View Herald Transcript
Harbormaster completed remote builds in B17871: Diff 44932.Jul 5 2018, 6:48 PM
andrew added a comment.Jul 5 2018, 6:50 PM

I still need to update vnet(9)

sys/net/vnet.h
273–277

I can add the same comment as DPCPU_DEFINE here

bz accepted this revision as: bz.Jul 7 2018, 2:16 PM

If you can sort out the pf_ioctl.c volatile issue first, and add the comment as you suggested this look good to me.

sys/net/vnet.h
273–277

Or a comment simply saying "/* See dpcpu for explanation. */".

sys/netpfil/pf/pf_ioctl.c
190

should this not fail to compile?

andrew updated this revision to Diff 45599.Jul 20 2018, 12:53 PM
  • Rebase
  • Update the man page (date will be changed when committed)
Harbormaster completed remote builds in B18202: Diff 45599.Jul 20 2018, 12:53 PM
andrew added inline comments.Jul 20 2018, 12:59 PM
sys/netpfil/pf/pf_ioctl.c
190

No, there is no struct _hack in the static macro. I'm not sure if the use of volatile is correct here, but haven't looked too deeply into it.

bz accepted this revision.Jul 20 2018, 1:07 PM
This revision is now accepted and ready to land.Jul 20 2018, 1:07 PM
Closed by commit rS336674: As with DPCPU create VNET_DEFINE_STATIC for when a variable needs to be (authored by andrew). · Explain WhyJul 24 2018, 4:31 PM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: manpages. · View Herald TranscriptJul 24 2018, 4:31 PM
Herald added a subscriber: imp. · View Herald Transcript
ae added a comment.Nov 19 2018, 9:50 AM

Hi, Andrew, do you plan to merge this into stable/11? It would be nice to have these macros to be able make MFC.

Revision Contents
Changeset List

PathSize
share/
man/
man9/
16 lines
sys/
contrib/
ipfilter/
netinet/
2 lines
net/
2 lines
4 lines
2 lines
24 lines
2 lines
2 lines
2 lines
12 lines
2 lines
2 lines
4 lines
4 lines
8 lines
10 lines
2 lines
2 lines
6 lines
2 lines
2 lines
2 lines
2 lines
11 lines
2 lines
netgraph/
14 lines
2 lines
2 lines
netinet/
cc/
14 lines
10 lines
6 lines
6 lines
4 lines
4 lines
4 lines
12 lines
26 lines
2 lines
6 lines
2 lines
14 lines
4 lines
2 lines
22 lines
20 lines
6 lines
36 lines
4 lines
10 lines
24 lines
4 lines
16 lines
8 lines
8 lines
2 lines
netinet6/
6 lines
4 lines
6 lines
4 lines
4 lines
2 lines
6 lines
10 lines
6 lines
8 lines
2 lines
2 lines
2 lines
netipsec/
8 lines
74 lines
2 lines
netpfil/
ipfw/
4 lines
8 lines
80 lines
6 lines
2 lines
nptv6/
2 lines
pmod/
2 lines
pf/
2 lines
8 lines
10 lines
12 lines
4 lines
8 lines
2 lines
10 lines

Diff 45599

View Options

share/man/man9/vnet.9

Loading...
View Options

sys/contrib/ipfilter/netinet/ip_rpcb_pxy.c

Loading...
View Options

sys/net/bpf.c

Loading...
View Options

sys/net/ieee8023ad_lacp.c

Loading...
View Options

sys/net/if.c

Loading...
View Options

sys/net/if_bridge.c

Loading...
View Options

sys/net/if_clone.c

Loading...
View Options

sys/net/if_disc.c

Loading...
View Options

sys/net/if_edsc.c

Loading...
View Options

sys/net/if_enc.c

Loading...
View Options

sys/net/if_epair.c

Loading...
View Options

sys/net/if_ethersubr.c

Loading...
View Options

sys/net/if_gif.c

Loading...
View Options

sys/net/if_gre.c

Loading...
View Options

sys/net/if_ipsec.c

Loading...
View Options

sys/net/if_lagg.c

Loading...
View Options

sys/net/if_llatbl.c

Loading...
View Options

sys/net/if_loop.c

Loading...
View Options

sys/net/if_me.c

Loading...
View Options

sys/net/if_vlan.c

Loading...
View Options

sys/net/netisr.c

Loading...
View Options

sys/net/route.c

Loading...
View Options

sys/net/rtsock.c

Loading...
View Options

sys/net/vnet.h

Loading...
View Options

sys/net/vnet.c

Loading...
View Options

sys/netgraph/ng_base.c

Loading...
View Options

sys/netgraph/ng_eiface.c

Loading...
View Options

sys/netgraph/ng_iface.c

Loading...
View Options

sys/netinet/cc/cc_cdg.c

Loading...
View Options

sys/netinet/cc/cc_chd.c

Loading...
View Options

sys/netinet/cc/cc_dctcp.c

Loading...
View Options

sys/netinet/cc/cc_hd.c

Loading...
View Options

sys/netinet/cc/cc_htcp.c

Loading...
View Options

sys/netinet/cc/cc_newreno.c

Loading...
View Options

sys/netinet/cc/cc_vegas.c

Loading...
View Options

sys/netinet/if_ether.c

Loading...
View Options

sys/netinet/igmp.c

Loading...
View Options

sys/netinet/in.c

Loading...
View Options

sys/netinet/in_gif.c

Loading...
View Options

sys/netinet/in_pcb.c

Loading...
View Options

sys/netinet/ip_carp.c

Loading...
View Options

sys/netinet/ip_divert.c

Loading...
View Options

sys/netinet/ip_gre.c

Loading...
View Options

sys/netinet/ip_icmp.c

Loading...
View Options

sys/netinet/ip_id.c

Loading...
View Options

sys/netinet/ip_input.c

Loading...
View Options

sys/netinet/ip_mroute.c

Loading...
View Options

sys/netinet/ip_options.c

Loading...
View Options

sys/netinet/ip_reass.c

Loading...
View Options

sys/netinet/tcp_fastopen.c

Loading...
View Options

sys/netinet/tcp_hostcache.c

Loading...
View Options

sys/netinet/tcp_subr.c

Loading...
View Options

sys/netinet/tcp_syncache.c

Loading...
View Options

sys/netinet/tcp_timewait.c

Loading...
View Options

sys/netinet/udp_usrreq.c

Loading...
View Options

sys/netinet6/frag6.c

Loading...
View Options

sys/netinet6/icmp6.c

Loading...
View Options

sys/netinet6/in6_gif.c

Loading...
View Options

sys/netinet6/in6_rmx.c

Loading...
View Options

sys/netinet6/in6_src.c

Loading...
View Options

sys/netinet6/ip6_gre.c

Loading...
View Options

sys/netinet6/ip6_mroute.c

Loading...
View Options

sys/netinet6/mld6.c

Loading...
View Options

sys/netinet6/nd6.c

Loading...
View Options

sys/netinet6/nd6_nbr.c

Loading...
View Options

sys/netinet6/nd6_rtr.c

Loading...
View Options

sys/netinet6/scope6.c

Loading...
View Options

sys/netinet6/send.c

Loading...
View Options

sys/netipsec/ipsec.c

Loading...
View Options

sys/netipsec/key.c

Loading...
View Options

sys/netipsec/keysock.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw2.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw_bpf.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw_dynamic.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw_pfil.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw_sockopt.c

Loading...
View Options

sys/netpfil/ipfw/nptv6/nptv6.c

Loading...
View Options

sys/netpfil/ipfw/pmod/tcpmod.c

Loading...
View Options

sys/netpfil/pf/if_pflog.c

Loading...
View Options

sys/netpfil/pf/if_pfsync.c

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_if.c

Loading...
View Options

sys/netpfil/pf/pf_ioctl.c

Loading...
View Options

sys/netpfil/pf/pf_norm.c

Loading...
View Options

sys/netpfil/pf/pf_osfp.c

Loading...
View Options

sys/netpfil/pf/pf_table.c

Loading...