Differential D16147

Create a macro for the static modifier with VNET
ClosedPublic
Actions

Authored by andrew on Jul 5 2018, 6:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 10, 9:01 AM

	Unknown Object (File)
	Nov 24 2024, 9:03 AM

	Unknown Object (File)
	Nov 20 2024, 9:08 AM

	Unknown Object (File)
	Oct 16 2024, 8:51 PM

	Unknown Object (File)
	Sep 27 2024, 10:45 AM

	Unknown Object (File)
	Sep 27 2024, 8:35 AM

	Unknown Object (File)
	Sep 24 2024, 5:41 PM

	Unknown Object (File)
	Sep 23 2024, 11:35 AM

View All 70 Files

Subscribers

Details

Reviewers

Group Reviewers

transport
manpages

Commits

rS336676: Use the new VNET_DEFINE_STATIC macro when we are defining static VNET
rS336674: As with DPCPU create VNET_DEFINE_STATIC for when a variable needs to be

Summary

As with DPCPU create a _STATIC version of VNET_DEFINE. This will allow us
to change this on arm64 later and enable VIMAGE.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jul 5 2018, 6:48 PM

Herald added a reviewer: transport. · View Herald TranscriptJul 5 2018, 6:48 PM

Herald added subscribers: farrokhi, ae. · View Herald Transcript

Harbormaster completed remote builds in B17871: Diff 44932.Jul 5 2018, 6:48 PM

I still need to update vnet(9)

sys/net/vnet.h
273 ↗	(On Diff #44932)	I can add the same comment as DPCPU_DEFINE here

If you can sort out the pf_ioctl.c volatile issue first, and add the comment as you suggested this look good to me.

sys/net/vnet.h
273 ↗	(On Diff #44932)	Or a comment simply saying "/* See dpcpu for explanation. */".
sys/netpfil/pf/pf_ioctl.c
190 ↗	(On Diff #44932)	should this not fail to compile?

Rebase
Update the man page (date will be changed when committed)

Harbormaster completed remote builds in B18202: Diff 45599.Jul 20 2018, 12:53 PM

andrew added inline comments.Jul 20 2018, 12:59 PM

sys/netpfil/pf/pf_ioctl.c
190 ↗	(On Diff #44932)	No, there is no struct _hack in the static macro. I'm not sure if the use of volatile is correct here, but haven't looked too deeply into it.

bz accepted this revision.Jul 20 2018, 1:07 PM

This revision is now accepted and ready to land.Jul 20 2018, 1:07 PM

Closed by commit rS336674: As with DPCPU create VNET_DEFINE_STATIC for when a variable needs to be (authored by andrew). · Explain WhyJul 24 2018, 4:31 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: manpages. · View Herald TranscriptJul 24 2018, 4:31 PM

Herald added a subscriber: imp. · View Herald Transcript

Hi, Andrew, do you plan to merge this into stable/11? It would be nice to have these macros to be able make MFC.

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man9/

16 lines

sys/

net/

10 lines

Diff 45785

head/share/man/man9/vnet.9

Loading...

head/sys/net/vnet.h

Loading...