top(1): Start parsing colors
Needs RevisionPublic
Actions

Authored by eadler on Jun 22 2018, 1:26 AM.

Details

Reviewers

Group Reviewers

manpages

Summary

This starts off parsing colors in a manner similar to that documented in
newer versions of the original top(1).

I wanted to get some early feedback though.

ref D15801 for what's blocking making use of the colors

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17531
Build 17354: arc lint + arc unit

add documentation stub to remind me to write more

Would it make sense to add an EXAMPLES section that shows how to define a proper TOPCOLOR?

In D15960#338171, @bcr wrote:

Would it make sense to add an EXAMPLES section that shows how to define a proper TOPCOLOR?

yeah. This isn't done or documented. Just threw this up here in order to (a) get feedback and (b) not lose it.

I think I've found some issues with mdoc formatting in the manual page.

usr.bin/top/top.1
196 ↗	(On Diff #44282)	Shouldn't there be a newline after ".Nm"? Also, it should be `Ev TOPCOLOR`.
197 ↗	(On Diff #44282)	`Ev TOPCOLOR`
383 ↗	(On Diff #44282)	Shouldn't we use `Ev` instead of `Pa` here?
384 ↗	(On Diff #44282)	Missing period at the end. Also, shouldn't we replace top with Nm here?
385 ↗	(On Diff #44282)	This should follow the "Default set of arguments to" line.