Page MenuHomeFreeBSD

top(1): Start parsing colors
Needs RevisionPublic

Authored by eadler on Jun 22 2018, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 1:43 PM
Unknown Object (File)
Dec 31 2023, 5:19 PM
Unknown Object (File)
Dec 23 2023, 11:24 AM
Unknown Object (File)
Dec 13 2023, 4:59 AM
Unknown Object (File)
Aug 15 2023, 1:54 AM
Unknown Object (File)
Jul 29 2023, 7:38 PM
Unknown Object (File)
Jul 25 2023, 1:36 AM
Unknown Object (File)
Jul 3 2023, 1:58 PM
Subscribers

Details

Reviewers
allanjude
rgrimes
0mp
Group Reviewers
manpages
Summary

This starts off parsing colors in a manner similar to that documented in
newer versions of the original top(1).

  • currently unimplemented: actually using the color
  • it doesn't deal well with malformed TOPCOLOR strings

I wanted to get some early feedback though.

ref D15801 for what's blocking making use of the colors

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17532
Build 17355: arc lint + arc unit

Event Timeline

add documentation stub to remind me to write more

Would it make sense to add an EXAMPLES section that shows how to define a proper TOPCOLOR?

In D15960#338171, @bcr wrote:

Would it make sense to add an EXAMPLES section that shows how to define a proper TOPCOLOR?

yeah. This isn't done or documented. Just threw this up here in order to (a) get feedback and (b) not lose it.

0mp requested changes to this revision.Aug 2 2018, 12:06 AM
0mp added a subscriber: 0mp.

I think I've found some issues with mdoc formatting in the manual page.

usr.bin/top/top.1
196

Shouldn't there be a newline after ".Nm"?

Also, it should be Ev TOPCOLOR.

197

Ev TOPCOLOR

383

Shouldn't we use Ev instead of Pa here?

384

Missing period at the end.

Also, shouldn't we replace top with Nm here?

385

This should follow the "Default set of arguments to" line.

This revision now requires changes to proceed.Aug 2 2018, 12:06 AM