Page MenuHomeFreeBSD
Differential D15892

Use information about max data size that the controller is able to operate
ClosedPublic
Actions

Authored by kibab on Jun 18 2018, 9:54 PM.
Tags
None
Referenced Files
F110598753: D15892.id55687.diff
Thu, Feb 20, 5:17 PM
Unknown Object (File)
Thu, Feb 6, 4:12 AM
Unknown Object (File)
Sat, Jan 25, 7:41 PM
Unknown Object (File)
Fri, Jan 24, 4:56 PM
Unknown Object (File)
Fri, Jan 24, 5:05 AM
Unknown Object (File)
Jan 18 2025, 5:54 PM
Unknown Object (File)
Dec 31 2024, 10:08 PM
Unknown Object (File)
Dec 9 2024, 5:58 PM
View All 65 Files
Subscribers
andrew
bz

Details

Reviewers
imp
manu
Commits
rS345775: Use information about max data size that the controller is able to operate
Summary

Using DFLTPHYS/MAXPHYS is not always OK, instead make it possible for the
controller driver to provide maximum data size to MMCCAM, and use it there.

The old stack already does this.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17425
Build 17257: arc lint + arc unit

Event Timeline

kibab created this revision.Jun 18 2018, 9:54 PM
Herald added a reviewer: manu. · View Herald TranscriptJun 18 2018, 9:54 PM
Harbormaster completed remote builds in B17425: Diff 44046.Jun 18 2018, 9:54 PM
kibab added a parent revision: D15891: Add MMCCAM support to AllWinner MMC driver.Jun 18 2018, 9:55 PM
manu accepted this revision.Jun 18 2018, 9:57 PM

The Allwinner part seems ok.

This revision is now accepted and ready to land.Jun 18 2018, 9:57 PM
kibab added 1 blocking reviewer(s): imp.Jun 19 2018, 11:29 AM
This revision now requires review to proceed.Jun 19 2018, 11:29 AM
imp added inline comments.Jul 18 2018, 10:23 PM
sys/cam/mmc/mmc_da.c
1514

min(<this stuff>, MAXPHYS);

sys/dev/sdhci/sdhci.c
2524

where does the mmc.host_maxa_data get set here? It looks like the break should be deleted and then 'else max_data = 65536;' added.

bz added a subscriber: bz.Nov 12 2018, 3:11 PM
kibab marked 2 inline comments as done.Mar 19 2019, 10:38 PM
Herald added a subscriber: andrew. · View Herald TranscriptMar 19 2019, 10:38 PM
kibab updated this revision to Diff 55256.Mar 19 2019, 10:43 PM
  • Address comments in D15892 wrt max_data setting and MIN(MAX_PHYS,...)
  • MIN(MAXPHYS) for D15892
Harbormaster completed remote builds in B23191: Diff 55256.Mar 19 2019, 10:43 PM
imp accepted this revision.Apr 1 2019, 6:24 PM
This revision is now accepted and ready to land.Apr 1 2019, 6:24 PM
Closed by commit rS345775: Use information about max data size that the controller is able to operate (authored by kibab). · Explain WhyApr 1 2019, 6:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
2 lines
cam/
1 line
mmc/
31 lines
dev/
sdhci/
14 lines

Diff 44046

View Options

sys/arm/allwinner/aw_mmc.c

Loading...
View Options

sys/cam/cam_ccb.h

Loading...
View Options

sys/cam/mmc/mmc_da.c

Loading...
View Options

sys/dev/sdhci/sdhci.c

Loading...