Page MenuHomeFreeBSD

Use information about max data size that the controller is able to operate
ClosedPublic

Authored by kibab on Jun 18 2018, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 13 2024, 2:11 PM
Unknown Object (File)
Dec 20 2023, 7:57 AM
Unknown Object (File)
Dec 11 2023, 3:32 AM
Unknown Object (File)
Sep 11 2023, 5:00 AM
Unknown Object (File)
Sep 7 2023, 10:23 PM
Unknown Object (File)
Sep 6 2023, 7:50 AM
Unknown Object (File)
Sep 1 2023, 11:47 PM
Unknown Object (File)
Aug 14 2023, 10:16 PM
Subscribers

Details

Summary

Using DFLTPHYS/MAXPHYS is not always OK, instead make it possible for the
controller driver to provide maximum data size to MMCCAM, and use it there.

The old stack already does this.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23191
Build 22234: arc lint + arc unit

Event Timeline

The Allwinner part seems ok.

This revision is now accepted and ready to land.Jun 18 2018, 9:57 PM
This revision now requires review to proceed.Jun 19 2018, 11:29 AM
sys/cam/mmc/mmc_da.c
1503

min(<this stuff>, MAXPHYS);

sys/dev/sdhci/sdhci.c
2606

where does the mmc.host_maxa_data get set here? It looks like the break should be deleted and then 'else max_data = 65536;' added.

  • Address comments in D15892 wrt max_data setting and MIN(MAX_PHYS,...)
  • MIN(MAXPHYS) for D15892
This revision is now accepted and ready to land.Apr 1 2019, 6:24 PM
This revision was automatically updated to reflect the committed changes.