Page MenuHomeFreeBSD
Differential D15890

Don't try to turn power down MMC bus if it is already down
ClosedPublic
Actions

Authored by kibab on Jun 18 2018, 9:14 PM.

Details

Reviewers
imp
Commits
rS335367: Don't try to turn power down MMC bus if it is already down
Summary

Regulator framework doens't like turning off already turned off
regulators, so we get panic on AllWinner boards.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kibab created this revision.Jun 18 2018, 9:14 PM
imp accepted this revision.Jun 18 2018, 9:36 PM
imp added inline comments.
sys/cam/mmc/mmc_xpt.c
585 ↗(On Diff #44038)

I'm not sure we're allowed to sleep here... But there's many other places we sleep so I'm not going to hold things up for that.

This revision is now accepted and ready to land.Jun 18 2018, 9:36 PM
kibab marked an inline comment as done.Jun 19 2018, 11:26 AM
kibab added inline comments.
sys/cam/mmc/mmc_xpt.c
585 ↗(On Diff #44038)

Strictly speaking, no sleeps should be here. But yes, eliminating sleeps is another problem.

Closed by commit rS335367: Don't try to turn power down MMC bus if it is already down (authored by kibab). · Explain WhyJun 19 2018, 11:29 AM
This revision was automatically updated to reflect the committed changes.
kibab marked an inline comment as done.

Revision Contents
Changeset List

Diff 44067

View Options

head/sys/cam/mmc/mmc_xpt.c

Loading...