Page MenuHomeFreeBSD
Differential D15890

Don't try to turn power down MMC bus if it is already down
ClosedPublic
Actions

Authored by kibab on Jun 18 2018, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 11:44 PM
Unknown Object (File)
Dec 11 2023, 2:20 AM
Unknown Object (File)
Nov 24 2023, 12:11 AM
Unknown Object (File)
Nov 5 2023, 11:11 PM
Unknown Object (File)
Sep 6 2023, 7:51 AM
Unknown Object (File)
Aug 14 2023, 10:16 PM
Unknown Object (File)
Aug 14 2023, 11:27 AM
Unknown Object (File)
Aug 10 2023, 4:31 PM
View All 19 Files
Subscribers
None

Details

Reviewers
imp
Commits
rS335367: Don't try to turn power down MMC bus if it is already down
Summary

Regulator framework doens't like turning off already turned off
regulators, so we get panic on AllWinner boards.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17421
Build 17253: arc lint + arc unit

Event Timeline

kibab created this revision.Jun 18 2018, 9:14 PM
Harbormaster completed remote builds in B17421: Diff 44038.Jun 18 2018, 9:14 PM
kibab added a child revision: D15891: Add MMCCAM support to AllWinner MMC driver.Jun 18 2018, 9:23 PM
imp accepted this revision.Jun 18 2018, 9:36 PM
imp added inline comments.
sys/cam/mmc/mmc_xpt.c
585

I'm not sure we're allowed to sleep here... But there's many other places we sleep so I'm not going to hold things up for that.

This revision is now accepted and ready to land.Jun 18 2018, 9:36 PM
kibab marked an inline comment as done.Jun 19 2018, 11:26 AM
kibab added inline comments.
sys/cam/mmc/mmc_xpt.c
585

Strictly speaking, no sleeps should be here. But yes, eliminating sleeps is another problem.

Closed by commit rS335367: Don't try to turn power down MMC bus if it is already down (authored by kibab). · Explain WhyJun 19 2018, 11:29 AM
This revision was automatically updated to reflect the committed changes.
kibab marked an inline comment as done.

Revision Contents
Changeset List

PathSize
sys/
cam/
mmc/
14 lines

Diff 44038

View Options

sys/cam/mmc/mmc_xpt.c

Loading...