Page MenuHomeFreeBSD
Differential D14985

ixl(4): Update to 1.9.9-k
ClosedPublic
Actions

Authored by krzysztof.galazka_intel.com on Apr 6 2018, 10:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 3:04 AM
Unknown Object (File)
Mon, Apr 8, 8:51 PM
Unknown Object (File)
Mon, Apr 8, 12:27 PM
Unknown Object (File)
Mon, Apr 8, 9:58 AM
Unknown Object (File)
Sun, Apr 7, 8:49 AM
Unknown Object (File)
Wed, Mar 27, 10:55 AM
Unknown Object (File)
Mar 5 2024, 9:51 AM
Unknown Object (File)
Feb 22 2024, 4:49 PM
View All Files
Subscribers
ae
erj
imp
jeffrey.e.pieper_intel.com
prakashs0234_gmail.com
smh

Details

Reviewers
sbruno
erj
jeffrey.e.pieper_intel.com
Group Reviewers
Intel Networking
Commits
rS333149: ixl(4): Update to 1.9.9-k
Summary

ixl(4): Update to 1.9.9-k

Refresh upstream driver before impending conversion to iflib.

Major changes:

  • Support for descriptor writeback mode
  • Ability to disable firmware LLDP agent by user (Bug 221530)
  • Fix for TX queue hang when using TSO (Bug 221919)
  • Separate descriptor ring sizes for TX and RX rings

Full history of changes in this update is available in GitHub repository: https://github.com/intel-wired-ethernet/freebsd/commits/ixl-update

Test Plan

I've tried compiling this on amd64 with no errors.

Respectfully request waiting for our Validation Team to perform a test pass before committing.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16280
Build 16227: arc lint + arc unit

Event Timeline

krzysztof.galazka_intel.com created this revision.Apr 6 2018, 10:33 AM
krzysztof.galazka_intel.com created this object with edit policy "Intel Networking (Project)".
Herald added subscribers: ae, imp. · View Herald TranscriptApr 6 2018, 10:33 AM
Harbormaster completed remote builds in B16011: Diff 41167.Apr 6 2018, 10:33 AM
jeffrey.e.pieper_intel.com added a subscriber: jeffrey.e.pieper_intel.com.Apr 6 2018, 1:56 PM
erj accepted this revision as: erj.Apr 8 2018, 6:37 PM
erj added a subscriber: erj.

I've reviewed this patch-by-patch; it all looks good to me. We just need to make sure validation says it compiles and does what it's supposed to, too.

jeffrey.e.pieper_intel.com requested changes to this revision.Apr 9 2018, 7:25 PM

Kernel panic with TCP bi-directional netperf traffic using 2 threads :

Fatal trap 12: page fault while in kernel mode
cpuid = 1; apic id = 01
fault virtual address = 0x0
fault code = supervisor write data, page not present
instruction pointer = 0x20:0xffffffff80d3dc64
stack pointer = 0x28:0xfffffe00ca86d8d0
frame pointer = 0x28:0xfffffe00ca86d900
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 12 (irq305: ixl0:q1)
[ thread pid 12 tid 101696 ]
Stopped at tcp_lro_flush_all+0x114: movq %rax,(%rcx)
db> where
Tracing pid 12 tid 101696 td 0xfffff800235f8560
tcp_lro_flush_all() at tcp_lro_flush_all+0x114/frame 0xfffffe00ca86d900
ixl_rxeof() at ixl_rxeof+0x5cb/frame 0xfffffe00ca86d990
ixl_msix_que() at ixl_msix_que+0x42/frame 0xfffffe00ca86d9e0
intr_event_execute_handlers() at intr_event_execute_handlers+0xe9 0xfffffe00ca86da20
ithread_loop() at ithread_loop+0xe7/frame 0xfffffe00ca86da70
fork_exit() at for_exeit+0x83/frame 0xfffffe00ca86dab0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00ca86dab0

  • trap 0, rip = 0, rsp = 0, rbp = 0 ---
This revision now requires changes to proceed.Apr 9 2018, 7:25 PM
krzysztof.galazka_intel.com updated this revision to Diff 41505.Apr 16 2018, 11:56 AM
  • Patch rebased on top of HEAD.
  • Fixed panic reported for TCP BX traffic.
Harbormaster completed remote builds in B16158: Diff 41505.Apr 16 2018, 11:56 AM
jeffrey.e.pieper_intel.com requested changes to this revision.Apr 17 2018, 12:02 AM

The panic is still reproducible, it just takes longer. See attached screen cap.

D14985-omni-performance-panic-bt.jpg (768×1 px, 137 KB)

This revision now requires changes to proceed.Apr 17 2018, 12:02 AM
smh added a subscriber: smh.Apr 17 2018, 9:54 AM

Is there anything happening with this as head is still 1.7.12-k which is very far behind the latest intel download which is 1.9.7?

krzysztof.galazka_intel.com added a comment.Apr 20 2018, 1:27 PM
In D14985#318249, @smh wrote:

Is there anything happening with this as head is still 1.7.12-k which is very far behind the latest intel download which is 1.9.7?

I'm sorry that investigation of this panic reported by Jeff took so long. The root cause has been identified - ixl_queue_hang_check function is triggering IRQs while queue is processed by ixl_handle_que task which leads to unsynchronized accesses to lro. I'm running some basic performance tests on the patch updating the review.

krzysztof.galazka_intel.com updated this revision to Diff 41797.Apr 24 2018, 1:08 PM
krzysztof.galazka_intel.com edited the summary of this revision. (Show Details)
  • Queue hang detection refactored to prevent kernel panic
  • Version bumped to 1.9.9 to align with out-of-tree driver
Harbormaster completed remote builds in B16280: Diff 41797.Apr 24 2018, 1:08 PM
krzysztof.galazka_intel.com updated this revision to Diff 41944.Apr 27 2018, 10:34 PM
krzysztof.galazka_intel.com retitled this revision from ixl(4): Update to 1.9.8-k to ixl(4): Update to 1.9.9-k.
  • Deduplicate queue hang detection code and use same method in PF and VF drivers. Fixes kernel panic on VF with TCP bi-directional traffic.
Harbormaster completed remote builds in B16323: Diff 41944.Apr 27 2018, 10:34 PM
jeffrey.e.pieper_intel.com accepted this revision.May 1 2018, 5:51 PM
This revision is now accepted and ready to land.May 1 2018, 5:51 PM
sbruno added a comment.May 13 2018, 3:41 PM

Is this to be committed to head? Are the Intel folks going to fire this off?

jeffrey.e.pieper_intel.com added a comment.May 14 2018, 1:52 PM

It was committed on 5-1 and MFC'ed to STABLE on 5-7, so I'm not sure why this wasn't closed.

sbruno closed this revision.May 14 2018, 2:03 PM
prakashs0234_gmail.com added a subscriber: prakashs0234_gmail.com.Jun 4 2018, 5:50 AM

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
dev/
ixl/
4 lines
45 lines
185 lines
2 lines
463 lines
224 lines
1385 lines
8 lines
2 lines
3 lines
2 lines
2 lines
450 lines
5 lines
52 lines
67 lines
4 lines
3 lines
90 lines
162 lines
559 lines
33 lines
4 lines
41 lines
2 lines
35 lines
2 lines
6 lines
311 lines
1180 lines
2 lines
2 lines
513 lines
13 lines
2 lines
273 lines
747 lines
modules/
ixl/
2 lines

Diff 41797

View Options

sys/conf/files.amd64

Loading...
View Options

sys/dev/ixl/i40e_adminq.h

Loading...
View Options

sys/dev/ixl/i40e_adminq.c

Loading...
View Options

sys/dev/ixl/i40e_adminq_cmd.h

Loading...
View Options

sys/dev/ixl/i40e_alloc.h

Loading...
View Options

sys/dev/ixl/i40e_common.c

Loading...
View Options

sys/dev/ixl/i40e_dcb.h

Loading...
View Options

sys/dev/ixl/i40e_dcb.c

Loading...
View Options

sys/dev/ixl/i40e_devids.h

Loading...
View Options

sys/dev/ixl/i40e_hmc.h

Loading...
View Options

sys/dev/ixl/i40e_hmc.c

Loading...
View Options

sys/dev/ixl/i40e_lan_hmc.h

Loading...
View Options

sys/dev/ixl/i40e_lan_hmc.c

Loading...
View Options

sys/dev/ixl/i40e_nvm.c

Loading...
View Options

sys/dev/ixl/i40e_osdep.h

Loading...
View Options

sys/dev/ixl/i40e_osdep.c

Loading...
View Options

sys/dev/ixl/i40e_prototype.h

Loading...
View Options

sys/dev/ixl/i40e_register.h

Loading...
View Options

sys/dev/ixl/i40e_status.h

Loading...
View Options

sys/dev/ixl/i40e_type.h

Loading...
View Options

sys/dev/ixl/i40e_virtchnl.h

Loading...
View Options

sys/dev/ixl/if_ixl.c

Loading...
View Options

sys/dev/ixl/if_ixlv.c

Loading...
View Options

sys/dev/ixl/ixl.h

Loading...
View Options

sys/dev/ixl/ixl_iw.h

Loading...
View Options

sys/dev/ixl/ixl_iw.c

Loading...
View Options

sys/dev/ixl/ixl_iw_int.h

Loading...
View Options

sys/dev/ixl/ixl_pf.h

Loading...
View Options

sys/dev/ixl/ixl_pf_i2c.c

Loading...
View Options

sys/dev/ixl/ixl_pf_iov.h

Loading...
View Options

sys/dev/ixl/ixl_pf_iov.c

Loading...
View Options

sys/dev/ixl/ixl_pf_main.c

Loading...
View Options

sys/dev/ixl/ixl_pf_qmgr.h

Loading...
View Options

sys/dev/ixl/ixl_pf_qmgr.c

Loading...
View Options

sys/dev/ixl/ixl_txrx.c

Loading...
View Options

sys/dev/ixl/ixlv.h

Loading...
View Options

sys/dev/ixl/ixlv_vc_mgr.h

Loading...
View Options

sys/dev/ixl/ixlvc.c

Loading...
View Options

sys/dev/ixl/virtchnl.h

Loading...
View Options

sys/modules/ixl/Makefile

Loading...