This is a part of D12559 containing only dlib ports. The review was done there.
Details
Details
- Reviewers
tcberner - Group Reviewers
Contributor Reviewers (ports) - Commits
- rP468383: New ports science/dlib-cpp and science/py-dlib (Python bindings for the former)
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 16178 Build 16131: arc lint + arc unit
Event Timeline
| science/dlib-cpp/Makefile | ||
|---|---|---|
| 27 | Without yet having looked at the CMakeLists.txt, couldn't you use CMAKE_BOOLs for the options? | |
Comment Actions
You also need to add them to science/Makefile
| science/dlib-cpp/Makefile | ||
|---|---|---|
| 4 | ^ How about using dlib and a PKGNAMESUFFIX? Instead of setting DISTNAME | |
| science/py-dlib/Makefile | ||
|---|---|---|
| 18 | python:2 is obsolete -- also is this really python2.x only? | |
| science/py-dlib/Makefile | ||
|---|---|---|
| 18 | Oops, I got lost in git and my branch was a bit behind. Sorry for putting this without testing. | |
| science/dlib-cpp/Makefile | ||
|---|---|---|
| 51 | Should go with USES. | |
Comment Actions
You need to add it to devel/Makefile too -- and you should use DISTVERSION instead of PORTVERSION; otherwise, it looks fine.
If you update it, I'll commit it later.
| head/science/dlib-cpp/Makefile | ||
|---|---|---|
| 46 ↗ | (On Diff #41907) | Missing @${PY_FLAVOR}. |