Page MenuHomeFreeBSD
Differential D14798

Add science/dlib-cpp and science/py-dlib ports.
ClosedPublic
Actions

Authored by arrowd on Mar 22 2018, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 10:58 AM
Unknown Object (File)
Mon, Dec 8, 11:22 PM
Unknown Object (File)
Mon, Dec 8, 11:15 PM
Unknown Object (File)
Sun, Dec 7, 4:45 AM
Unknown Object (File)
Sat, Nov 29, 6:33 PM
Unknown Object (File)
Tue, Nov 25, 9:19 AM
Unknown Object (File)
Sun, Nov 23, 11:10 AM
Unknown Object (File)
Nov 5 2025, 1:19 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
Group Reviewers
Contributor Reviewers (ports)
Commits
rP468383: New ports science/dlib-cpp and science/py-dlib (Python bindings for the former)
Summary

This is a part of D12559 containing only dlib ports. The review was done there.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arrowd created this revision.Mar 22 2018, 4:44 PM
Harbormaster completed remote builds in B15722: Diff 40602.Mar 22 2018, 4:44 PM
tcberner added inline comments.Mar 22 2018, 5:11 PM
science/dlib-cpp/Makefile
26 ↗(On Diff #40602)

Without yet having looked at the CMakeLists.txt, couldn't you use CMAKE_BOOLs for the options?

tcberner added a comment.Mar 22 2018, 5:14 PM

You also need to add them to science/Makefile

science/dlib-cpp/Makefile
3 ↗(On Diff #40602)

^ How about using dlib and a PKGNAMESUFFIX? Instead of setting DISTNAME

tcberner added inline comments.Mar 22 2018, 5:39 PM
science/dlib-cpp/Makefile
4 ↗(On Diff #40602)

DISTVERSION is prefered

14 ↗(On Diff #40602)

I would sort these alphabetically

tcberner added inline comments.Mar 22 2018, 5:48 PM
science/py-dlib/Makefile
17 ↗(On Diff #40602)

python:2 is obsolete -- also is this really python2.x only?

mat added a subscriber: mat.Mar 22 2018, 6:06 PM
mat added inline comments.
science/dlib-cpp/Makefile
12 ↗(On Diff #40602)

LICENSE_FILE?

science/py-dlib/Makefile
12 ↗(On Diff #40602)

LICENSE_FILE?

15 ↗(On Diff #40602)

${PY_BOOST}

17 ↗(On Diff #40602)

python:2 is not obsolete, it is unsupported, so, this does not build.
Was all this review tested?

arrowd updated this revision to Diff 41001.Apr 2 2018, 7:59 PM
arrowd marked 9 inline comments as done.
  • Address review comments.
Harbormaster completed remote builds in B15947: Diff 41001.Apr 2 2018, 7:59 PM
arrowd added inline comments.Apr 2 2018, 8:01 PM
science/py-dlib/Makefile
17 ↗(On Diff #40602)

Oops, I got lost in git and my branch was a bit behind. Sorry for putting this without testing.

mat added inline comments.Apr 3 2018, 1:50 PM
science/dlib-cpp/Makefile
50 ↗(On Diff #41001)

Should go with USES.

arrowd updated this revision to Diff 41023.Apr 3 2018, 3:51 PM
arrowd marked an inline comment as done.
  • Move USE_LDCONFIG near USES.
Harbormaster completed remote builds in B15957: Diff 41023.Apr 3 2018, 3:51 PM
tcberner added a comment.Apr 16 2018, 2:53 PM

You need to add it to devel/Makefile too -- and you should use DISTVERSION instead of PORTVERSION; otherwise, it looks fine.

If you update it, I'll commit it later.

arrowd updated this revision to Diff 41553.Apr 16 2018, 8:46 PM
  • Use DISTVERSION in py-dlib and add new ports to science/Makefile.
Harbormaster completed remote builds in B16178: Diff 41553.Apr 16 2018, 8:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2018, 8:39 PM
Closed by commit rP468383: New ports science/dlib-cpp and science/py-dlib (Python bindings for the former) (authored by adridg). · Explain Why
This revision was automatically updated to reflect the committed changes.
mat added inline comments.May 14 2018, 10:49 PM
head/science/dlib-cpp/Makefile
46

Missing @${PY_FLAVOR}.

Revision Contents
Changeset List

PathSize
head/
science/
2 lines
dlib-cpp/
51 lines
3 lines
7 lines
973 lines
py-dlib/
57 lines
3 lines
files/
30 lines
35 lines
7 lines

Diff 41907

View Options

head/science/Makefile

Loading...
View Options

head/science/dlib-cpp/Makefile

Loading...
View Options

head/science/dlib-cpp/distinfo

Loading...
View Options

head/science/dlib-cpp/pkg-descr

Loading...
View Options

head/science/dlib-cpp/pkg-plist

Loading...
View Options

head/science/py-dlib/Makefile

Loading...
View Options

head/science/py-dlib/distinfo

Loading...
View Options

head/science/py-dlib/files/patch-dlib_cmake__utils_add__python__module

Loading...
View Options

head/science/py-dlib/files/patch-setup.py

Loading...
View Options

head/science/py-dlib/pkg-descr

Loading...