Add science/dlib-cpp and science/py-dlib ports.

[arrowd]

Summary

This is a part of D12559 containing only dlib ports. The review was done there.

[tcberner]

science/dlib-cpp/Makefile

26

Without yet having looked at the CMakeLists.txt, couldn't you use CMAKE_BOOLs for the options?

[tcberner]

You also need to add them to science/Makefile

science/dlib-cpp/Makefile

3

^ How about using dlib and a PKGNAMESUFFIX? Instead of setting DISTNAME

[tcberner]

science/dlib-cpp/Makefile

4

DISTVERSION is prefered

14

I would sort these alphabetically

[tcberner]

science/py-dlib/Makefile

17

python:2 is obsolete -- also is this really python2.x only?

[mat]

science/dlib-cpp/Makefile

12

LICENSE_FILE?

science/py-dlib/Makefile

12

LICENSE_FILE?

15

${PY_BOOST}

17

python:2 is not obsolete, it is unsupported, so, this does not build.
Was all this review tested?

[arrowd]

• Address review comments.

[arrowd]

science/py-dlib/Makefile

17

Oops, I got lost in git and my branch was a bit behind. Sorry for putting this without testing.

[mat]

science/dlib-cpp/Makefile

51

Should go with USES.

[arrowd]

• Move USE_LDCONFIG near USES.

[tcberner]

You need to add it to devel/Makefile too -- and you should use DISTVERSION instead of PORTVERSION; otherwise, it looks fine.

If you update it, I'll commit it later.

[arrowd]

• Use DISTVERSION in py-dlib and add new ports to science/Makefile.

[mat]

head/science/dlib-cpp/Makefile

46 ↗

(On Diff #41907)

Missing @${PY_FLAVOR}.