WIP: Dlib, Torch7, OpenFace
AbandonedPublic
Actions

Authored by arrowd on Oct 1 2017, 8:16 PM.

Details

Reviewers

mat

Group Reviewers

Contributor Reviewers (ports)

Summary

This is WIP diff adding ports for

Dlib C++ library
Torch7 scientific framework
OpenFace python library for face detection

There are numerous TODOs, but it started to get too complex, so I wanted to share my work.

Current problems:

Enable support for various Dlib options
BLAS support in Dlib doesn't work with default BLAS library (netlib). The problem is subtle, I've notified maintainer about this. At the same time, Torch7 defaults to openblas, so maybe it is better to just use it for Dlib too?
There is no luajit support in lua.mk. This made me hard code some paths in the makefiles. Moreover, ports like devel/lua-cwrap can also work with lua5*, and I havem't figured out how to handle this case. The upcoming FLAVORS support might fix this, but I'd rather stick to more old-school handling.

I plan to gradually fix issues and extend torch7-* ports, but any help is welcome.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 12202
Build 12499: arc lint + arc unit

Event Timeline

arrowd created this revision.Oct 1 2017, 8:16 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptOct 1 2017, 8:16 PM

mat requested changes to this revision.Oct 6 2017, 3:10 PM

mat added inline comments.

devel/lua-cwrap/Makefile
20	Default, remove.
devel/lua-penlight/Makefile
17 ↗	(On Diff #33613)	`PORTNAME` should be `Penlight`, and then you can remove this line.
devel/torch7-sys/Makefile
21	Default, remove.
graphics/py-openface/Makefile
22–25	Out of order. See Chapter 14. Order of Variables in Port Makefiles.
science/dlib-cpp/Makefile
15–19	Out of order. See Chapter 14. Order of Variables in Port Makefiles.
science/py-dlib/Makefile
18–22	Out of order. See Chapter 14. Order of Variables in Port Makefiles.
30–46	Use 5.13.3.9. <opt>_VARS and <opt>_VARS_OFF.
science/torch7-main/Makefile
4	PORTNAME=torch7 PKGNAMESUFFIX=-main And then remove GH_PROJECT.
22	Default, remove.
science/torch7-repl/Makefile
23	Remove

This revision now requires changes to proceed.Oct 6 2017, 3:10 PM

Address comments. Support all options in dlib port. Incorporate some upstream fixes.

BLASLAPACK support in both dlib-cpp and py-dlib is currently problematic, because it pulls in
GCC. In dlib-cpp case this leads to crashes in testsuite, while py-dlib simply doesn't compile.

Torch7 ports are also still in bad shape - torch7-repl doesn't seem to find modules installed by other torch7-* packages.
I'm going to address this on next iteration.

Apart from BLASLAPACK option, I think dlib-cpp and py-dlib can be commited.

Harbormaster completed remote builds in B12202: Diff 34290.Oct 24 2017, 3:05 PM

mat added inline comments.Oct 26 2017, 3:06 PM

devel/lua-Penlight/Makefile
19–20	I do not think hardcoding 5.1 here is a good idea.

ultima added a subscriber: ultima.Oct 26 2017, 4:08 PM

ultima added inline comments.

devel/lua-Penlight/pkg-plist
1	Also not a good idea to hard code the lua version in plist, when the default version changes or set to a different value all (or at least most) of these ports will break.