This is a part of D12559 containing only dlib ports. The review was done there.
Details
Details
- Reviewers
tcberner - Group Reviewers
Contributor Reviewers (ports) - Commits
- rP468383: New ports science/dlib-cpp and science/py-dlib (Python bindings for the former)
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| science/dlib-cpp/Makefile | ||
|---|---|---|
| 26 ↗ | (On Diff #40602) | Without yet having looked at the CMakeLists.txt, couldn't you use CMAKE_BOOLs for the options? |
Comment Actions
You also need to add them to science/Makefile
| science/dlib-cpp/Makefile | ||
|---|---|---|
| 3 ↗ | (On Diff #40602) | ^ How about using dlib and a PKGNAMESUFFIX? Instead of setting DISTNAME |
| science/py-dlib/Makefile | ||
|---|---|---|
| 17 ↗ | (On Diff #40602) | python:2 is obsolete -- also is this really python2.x only? |
| science/py-dlib/Makefile | ||
|---|---|---|
| 17 ↗ | (On Diff #40602) | Oops, I got lost in git and my branch was a bit behind. Sorry for putting this without testing. |
| science/dlib-cpp/Makefile | ||
|---|---|---|
| 50 ↗ | (On Diff #41001) | Should go with USES. |
Comment Actions
You need to add it to devel/Makefile too -- and you should use DISTVERSION instead of PORTVERSION; otherwise, it looks fine.
If you update it, I'll commit it later.
| head/science/dlib-cpp/Makefile | ||
|---|---|---|
| 46 | Missing @${PY_FLAVOR}. | |