Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
F163092274: D14937.id40998.diff
Mon, Jul 20, 12:31 AM
Unknown Object (File)
Mon, Jul 13, 6:04 AM
Unknown Object (File)
Wed, Jul 1, 2:04 PM
Unknown Object (File)
Wed, Jul 1, 2:02 PM
Unknown Object (File)
Tue, Jun 30, 3:31 PM
Unknown Object (File)
Sat, Jun 27, 6:26 AM
Unknown Object (File)
Fri, Jun 26, 1:53 PM
Unknown Object (File)
Wed, Jun 24, 6:53 PM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15944
Build 15936: arc lint + arc unit