Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
F157361092: D14937.id40998.diff
Wed, May 20, 2:55 PM
Unknown Object (File)
Wed, May 20, 5:44 AM
Unknown Object (File)
Tue, May 19, 10:51 PM
Unknown Object (File)
Sun, May 17, 12:13 AM
Unknown Object (File)
Wed, May 6, 3:15 PM
Unknown Object (File)
Mon, May 4, 2:43 AM
Unknown Object (File)
Thu, Apr 30, 12:35 AM
Unknown Object (File)
Wed, Apr 29, 1:48 PM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15944
Build 15936: arc lint + arc unit