Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
F173024514: D14937.id40998.diff
Tue, Sep 22, 11:14 PM
F173024156: D14937.id41018.diff
Tue, Sep 22, 11:10 PM
F173023680: D14937.diff
Tue, Sep 22, 11:05 PM
Unknown Object (File)
Fri, Sep 11, 1:31 AM
Unknown Object (File)
Tue, Sep 8, 3:37 AM
Unknown Object (File)
Sat, Sep 5, 2:07 AM
Unknown Object (File)
Fri, Sep 4, 10:00 PM
Unknown Object (File)
Fri, Sep 4, 4:38 AM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15944
Build 15936: arc lint + arc unit