Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 29, 9:38 AM
Unknown Object (File)
Dec 26 2023, 6:52 AM
Unknown Object (File)
Dec 26 2023, 6:52 AM
Unknown Object (File)
Dec 26 2023, 6:52 AM
Unknown Object (File)
Dec 26 2023, 6:39 AM
Unknown Object (File)
Dec 24 2023, 11:43 AM
Unknown Object (File)
Dec 20 2023, 3:23 AM
Unknown Object (File)
Dec 13 2023, 5:28 AM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable