Page MenuHomeFreeBSD

Fix LRO window comparison
ClosedPublic

Authored by jtl on Apr 2 2018, 6:46 PM.
Tags
None
Referenced Files
F135480308: D14937.id.diff
Mon, Nov 10, 5:12 AM
F135472705: D14937.id40998.diff
Mon, Nov 10, 3:55 AM
Unknown Object (File)
Mon, Nov 10, 12:55 AM
Unknown Object (File)
Sun, Nov 9, 1:28 PM
Unknown Object (File)
Sat, Nov 8, 3:46 PM
Unknown Object (File)
Thu, Oct 30, 5:20 PM
Unknown Object (File)
Mon, Oct 27, 7:53 AM
Unknown Object (File)
Sun, Oct 26, 10:22 PM
Subscribers

Details

Summary

rS330675 (D14540) introduced an extra window check in the LRO code to ensure it captured and reported the highest window advertisement with the same SEQ/ACK. However, the window comparison uses a two's complement comparison rather than a comparison of the absolute values. Because windows use absolute values, rather than two's complement arithmetic (i.e. they don't wrap), compare the absolute values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15944
Build 15936: arc lint + arc unit