Page MenuHomeFreeBSD

Keep CARP state as INIT when net.inet.carp.allow=0
ClosedPublic

Authored by wg on Feb 23 2018, 1:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 6:13 PM
Unknown Object (File)
Feb 27 2024, 3:00 PM
Unknown Object (File)
Feb 20 2024, 12:42 PM
Unknown Object (File)
Feb 15 2024, 12:27 PM
Unknown Object (File)
Dec 28 2023, 6:11 PM
Unknown Object (File)
Dec 23 2023, 4:08 AM
Unknown Object (File)
Dec 18 2023, 4:47 PM
Unknown Object (File)
Nov 28 2023, 7:59 PM
Subscribers

Details

Summary

Currently when net.inet.carp.allow=0 CARP state remains as MASTER
which is not very useful. Having it as INIT makes it clear carp packets are disabled.

With the help of Alexander Motin we came up with the following patch.

Let me know what you think, thanks.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15212
Build 15284: arc lint + arc unit

Event Timeline

wg edited the summary of this revision. (Show Details)

Removing needless sx lock

Remove unneeded condition and missing space after if

After all the changes I think it would be a good addition. Existing allow sysctl is useless IMO, while this change adds sense to it.

This revision is now accepted and ready to land.Feb 23 2018, 3:07 PM
This revision was automatically updated to reflect the committed changes.