Page MenuHomeFreeBSD

Keep CARP state as INIT when net.inet.carp.allow=0
ClosedPublic

Authored by wg on Feb 23 2018, 1:02 AM.

Details

Summary

Currently when net.inet.carp.allow=0 CARP state remains as MASTER
which is not very useful. Having it as INIT makes it clear carp packets are disabled.

With the help of Alexander Motin we came up with the following patch.

Let me know what you think, thanks.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15211
Build 15283: arc lint + arc unit

Event Timeline

wg created this revision.Feb 23 2018, 1:02 AM
wg edited the summary of this revision. (Show Details)Feb 23 2018, 1:02 AM
wg edited the summary of this revision. (Show Details)
wg updated this revision to Diff 39627.Feb 23 2018, 1:15 AM

Removing needless sx lock

wg updated this revision to Diff 39628.Feb 23 2018, 1:40 AM

Do not use taskqueue

wg updated this revision to Diff 39629.Feb 23 2018, 1:42 AM

Remove extra line

wg updated this revision to Diff 39630.Feb 23 2018, 1:48 AM

Wrap long line

wg updated this revision to Diff 39643.Feb 23 2018, 11:59 AM

Remove unneeded condition and missing space after if

mav accepted this revision.Feb 23 2018, 3:07 PM

After all the changes I think it would be a good addition. Existing allow sysctl is useless IMO, while this change adds sense to it.

This revision is now accepted and ready to land.Feb 23 2018, 3:07 PM
This revision was automatically updated to reflect the committed changes.