Page MenuHomeFreeBSD
Differential D14477

Keep CARP state as INIT when net.inet.carp.allow=0
ClosedPublic
Actions

Authored by wg on Feb 23 2018, 1:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 12:07 PM
Unknown Object (File)
Sat, Dec 21, 10:38 AM
Unknown Object (File)
Sat, Dec 21, 8:42 AM
Unknown Object (File)
Sun, Dec 15, 10:11 PM
Unknown Object (File)
Sun, Dec 15, 10:08 PM
Unknown Object (File)
Sat, Dec 14, 8:12 AM
Unknown Object (File)
Nov 25 2024, 5:37 AM
Unknown Object (File)
Nov 5 2024, 10:47 AM
View All 100 Files
Subscribers
imp

Details

Reviewers
mav
glebius
Group Reviewers
network
manpages
Commits
rS333322: Keep CARP state as INIT when net.inet.carp.allow=0.
Summary

Currently when net.inet.carp.allow=0 CARP state remains as MASTER
which is not very useful. Having it as INIT makes it clear carp packets are disabled.

With the help of Alexander Motin we came up with the following patch.

Let me know what you think, thanks.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15215
Build 15287: arc lint + arc unit

Event Timeline

wg created this revision.Feb 23 2018, 1:02 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2018, 1:02 AM
wg edited the summary of this revision. (Show Details)Feb 23 2018, 1:02 AM
wg edited the summary of this revision. (Show Details)
wg updated this revision to Diff 39627.Feb 23 2018, 1:15 AM

Removing needless sx lock

Harbormaster completed remote builds in B15212: Diff 39627.Feb 23 2018, 1:15 AM
wg added reviewers: network, glebius.Feb 23 2018, 1:16 AM
wg updated this revision to Diff 39628.Feb 23 2018, 1:40 AM

Do not use taskqueue

wg updated this revision to Diff 39629.Feb 23 2018, 1:42 AM

Remove extra line

Harbormaster completed remote builds in B15214: Diff 39629.Feb 23 2018, 1:42 AM
wg updated this revision to Diff 39630.Feb 23 2018, 1:48 AM

Wrap long line

Harbormaster completed remote builds in B15215: Diff 39630.Feb 23 2018, 1:48 AM
wg updated this revision to Diff 39643.Feb 23 2018, 11:59 AM

Remove unneeded condition and missing space after if

Harbormaster completed remote builds in B15222: Diff 39643.Feb 23 2018, 11:59 AM
mav accepted this revision.Feb 23 2018, 3:07 PM

After all the changes I think it would be a good addition. Existing allow sysctl is useless IMO, while this change adds sense to it.

This revision is now accepted and ready to land.Feb 23 2018, 3:07 PM
Closed by commit rS333322: Keep CARP state as INIT when net.inet.carp.allow=0. (authored by mav). · Explain WhyMay 7 2018, 2:45 PM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: manpages. · View Herald TranscriptMay 7 2018, 2:45 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
40 lines

Diff 39630

View Options

sys/netinet/ip_carp.c

Loading...