Page MenuHomeFreeBSD

Make cam_periph_runccb be safe to call when we can only do polling.
ClosedPublic

Authored by imp on Dec 6 2017, 1:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 9, 1:33 AM
Unknown Object (File)
Feb 17 2024, 12:24 PM
Unknown Object (File)
Jan 6 2024, 8:29 PM
Unknown Object (File)
Dec 29 2023, 12:07 AM
Unknown Object (File)
Dec 20 2023, 7:51 AM
Unknown Object (File)
Dec 2 2023, 9:28 AM
Unknown Object (File)
Nov 6 2023, 1:59 AM
Unknown Object (File)
Oct 9 2023, 8:18 PM
Subscribers
None

Details

Summary

Make cam_periph_runccb() safe for calling when we have to poll. Update
to reflect that cam_periph_runccb() can be called from situations
where the kernel scheduler is stopped, replace the by hand calling of
xpt_polled_action() with it.

Sponsored by: Netflix

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13385
Build 13617: arc lint + arc unit

Event Timeline

sys/cam/cam_periph.c
1212

Maybe name it pollwait for consistency with ccbwait. To me poll alone implies checking once, rather than the timeout sleep-wait-retry loop xpt_poll implements.

sys/cam/cam_xpt.c
3249–3250

inconsistent whitespace here

3252

What's the point of passing a timeout argument if it is immediately overwritten?

3256

style(9) nit: whitespace

3263

extra whitespace here

3284

inconsistent whitespace

imp marked 6 inline comments as done.Dec 6 2017, 4:38 PM
imp added inline comments.
sys/cam/cam_xpt.c
3249–3250

the whitespace is now consistent, but phab is having fits with tabs.

3284

It's now consistent, but again, phab is having rendering issues.

This revision is now accepted and ready to land.Dec 6 2017, 5:31 PM
This revision was automatically updated to reflect the committed changes.
imp marked 2 inline comments as done.