Page MenuHomeFreeBSD
Differential D1550

Add a sanity check to freebsd-update to disallow a 'fetch' if there are uninstalled upgraded pending Add a -F parameter to override the new behaviour. This also allows fetch to be run without a tty.
ClosedPublic
Actions

Authored by allanjude on Jan 17 2015, 6:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 4:43 PM
Unknown Object (File)
Wed, Dec 11, 1:11 AM
Unknown Object (File)
Wed, Nov 27, 5:05 AM
Unknown Object (File)
Fri, Nov 22, 10:56 AM
Unknown Object (File)
Thu, Nov 21, 3:10 PM
Unknown Object (File)
Thu, Nov 21, 1:05 PM
Unknown Object (File)
Nov 19 2024, 4:21 AM
Unknown Object (File)
Nov 18 2024, 3:30 AM
View All Files
Subscribers
delphij
dvl
imp

Details

Reviewers
• rodrigc
delphij
wblock
dvl
cperciva
bcr
Commits
rS279571: Add a new safetly belt to freebsd-update to prevent a user doing a minor update…
Summary

Update man page with modern versions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

allanjude updated this revision to Diff 3223.Jan 17 2015, 6:39 AM
allanjude retitled this revision from to Add a sanity check to freebsd-update to disallow a 'fetch' if there are uninstalled upgraded pending Add a -F parameter to override the new behaviour. This also allows fetch to be run without a tty. Update man page with modern versions..
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)
allanjude added a reviewer: cperciva.
allanjude added a comment.Jan 17 2015, 6:49 AM

Some users have run into an unexpected issue while using freebsd-update

The issue is user error, but hopefully we can add a safety belt to freebsd-update to prevent this type of foot shooting

user has a FreeBSD 9.2-RELEASE-pX system

freebsd-update upgrade -r 9.3-RELEASE
freebsd-update install
reboot

user forgets to install world, and remove old libs

uname -a shows 9.3, user is happy

world is still 9.2

months later, user wants to update from 9.3 to 9.3-p8 to get openssl fixes

freebsd-update fetch
freebsd-update install

now sshd is broken, because it has been upgraded, but libssh has not, so there is no ssh_explicit_bzero etc

Proposed fix: do not allow a 'freebsd-update fetch' again, until they finish the previously pending 'freebsd-update install's required.

Related:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196760
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196771

usr.sbin/freebsd-update/freebsd-update.sh
685

This is probably not a smart enough check.

We only want to block 'fetch' if there is an in-progress 'upgrade' going on. Where the user has installed a new kernel, but has not finished installing the new world yet.

allanjude updated this revision to Diff 3224.Jan 17 2015, 7:30 AM
allanjude retitled this revision from Add a sanity check to freebsd-update to disallow a 'fetch' if there are uninstalled upgraded pending Add a -F parameter to override the new behaviour. This also allows fetch to be run without a tty. Update man page with modern versions. to Add a sanity check to freebsd-update to disallow a 'fetch' if there are uninstalled upgraded pending Add a -F parameter to override the new behaviour. This also allows fetch to be run without a tty..
allanjude updated this object.

Improve the sanity check to look for an installed kernel, so it doesn't trigger if the user has been using 'freebsd-update cron' and just has minor patches pending

Once world is installed, and the oldlibs removal is complete, the -install symlink is renamed -rollback

Updating D1550: Add a sanity check to freebsd-update to disallow a 'fetch' if there are uninstalled upgraded pending

Add a -F parameter to override the new behaviour. This also allows fetch to be run without a tty.

dvl accepted this revision.Jan 18 2015, 8:41 PM
dvl added a reviewer: dvl.
dvl added a subscriber: dvl.

I like this idea, but am unable to test just now.

This revision is now accepted and ready to land.Jan 18 2015, 8:41 PM
• rodrigc accepted this revision.Jan 25 2015, 11:03 PM
• rodrigc added a reviewer: • rodrigc.
• rodrigc edited edge metadata.
cperciva edited edge metadata.Jan 25 2015, 11:10 PM

I like the added sanity-check for partially-installed upgrades. But I think disabling the notty check should be a different option, e.g., --not-running-from-cron since otherwise we'll see 1. people complaining that fetch doesn't work from cron, 2. people replying to say "just add -F", 3. networks falling over under synchronized load; whereas --not-running-from-cron is a sufficiently descriptive option name that people *might* think twice before adding that to their cron jobs.

allanjude updated this revision to Diff 3451.Jan 27 2015, 12:19 AM
allanjude edited edge metadata.

Updated with Colin's feedback

This revision now requires review to proceed.Jan 27 2015, 12:19 AM
cperciva added a comment.Jan 27 2015, 4:35 AM

Please do not run
.Nm
from crontab or similar using this flag, see:
.Nm Cm fetch

s/fetch/cron/ ?

allanjude updated this revision to Diff 3452.Jan 27 2015, 5:03 AM
allanjude edited edge metadata.

Fix manpage typo

Updating D1550: Add a sanity check to freebsd-update to disallow a 'fetch' if there are uninstalled upgraded pending

Add a -F parameter to override the new behaviour. This also allows fetch to be run without a tty.

allanjude added a comment.Jan 27 2015, 5:03 AM

Good catch

• rodrigc accepted this revision.Jan 29 2015, 5:30 PM
• rodrigc edited edge metadata.

Latest patch with --not-running-from-cron
looks good to me. @cperciva does it look good to you?

This revision is now accepted and ready to land.Jan 29 2015, 5:30 PM
cperciva added a comment.Jan 29 2015, 8:54 PM

What's the s/-f conffile/-f newrelease/ bit doing in the man page?

I'd put the new options at the end of the list in the SYNOPSYS.

allanjude updated this revision to Diff 3526.Jan 29 2015, 10:59 PM
allanjude edited edge metadata.

Fix manpage issues identified by cperciva

Updating D1550: Add a sanity check to freebsd-update to disallow a 'fetch' if there are uninstalled upgraded pending

Add a -F parameter to override the new behaviour. This also allows fetch to be run without a tty.

This revision now requires review to proceed.Jan 29 2015, 10:59 PM
cperciva added a comment.Jan 29 2015, 11:30 PM

Looks fine to me.

allanjude added reviewers: wblock, bcr.Feb 1 2015, 12:24 AM
bcr added inline comments.Feb 1 2015, 11:58 AM
usr.sbin/freebsd-update/freebsd-update.8
111

Hmm, are we endorsing products here? I see the intention to give examples and I use some of these myself. I just want to avoid that similar solutions file PRs wanting to be listed there as well. Maybe we can phrase this less product specific while still making it clear what we mean?

wblock added inline comments.Feb 2 2015, 2:18 AM
usr.sbin/freebsd-update/freebsd-update.8
111

There might also be an issue with this page still being around long after the named programs are gone. I can't think of a generic term for them right now, but there should be one.

If names are going to be mentioned, they should be capitalized.

bcr added inline comments.Feb 18 2015, 7:28 PM
usr.sbin/freebsd-update/freebsd-update.8
111

How about just writing "This is for use by automated tools." for now? This would keep the issue from stalling and we can always add more details to the handbook with concrete examples.

• rodrigc added a comment.Mar 2 2015, 1:50 AM

I agree with @bcr
@allanjude can you implement @bcr's suggestion, and remove all references
to specific automation frameworks in your patch? If you can do that,
and commit this patch that would be great.

allanjude updated this revision to Diff 4080.Mar 3 2015, 2:20 AM

Update manpage entry as requested

allanjude added a comment.Mar 3 2015, 2:22 AM
In D1550#35, @rodrigc wrote:

If you can do that,
and commit this patch that would be great.

As I am only a doc committer, I need an "approved by" from someone with a src bit to commit this. (this signoff from a mentor for the docs part)

bcr accepted this revision.Mar 3 2015, 7:39 AM
bcr edited edge metadata.

OK for the doc part of the change.

This revision is now accepted and ready to land.Mar 3 2015, 7:39 AM
• rodrigc accepted this revision.EditedMar 3 2015, 7:49 AM
• rodrigc edited edge metadata.

That looks legit, you must commit!

delphij accepted this revision.Mar 3 2015, 8:13 PM
delphij added a reviewer: delphij.
delphij added a subscriber: delphij.

Looks good to me, ship it!

allanjude closed this revision.Mar 3 2015, 11:20 PM
allanjude updated this revision to Diff 4097.

Closed by commit rS279571 (authored by @allanjude).

allanjude reopened this revision.Mar 26 2015, 3:36 PM
This revision is now accepted and ready to land.Mar 26 2015, 3:36 PM
allanjude updated this revision to Diff 4437.Mar 26 2015, 3:36 PM
allanjude edited edge metadata.

Fix a syntax problem reported by Kris Moore

Obtained From: pcbsd

This revision now requires review to proceed.Mar 26 2015, 3:36 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 26 2015, 3:36 PM
delphij accepted this revision.Mar 26 2015, 5:27 PM
delphij edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Mar 26 2015, 5:27 PM
allanjude closed this revision.May 16 2015, 6:25 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
freebsd-update/
18 lines
16 lines

Diff 3223

View Options

usr.sbin/freebsd-update/freebsd-update.8

Loading...
View Options

usr.sbin/freebsd-update/freebsd-update.sh

Loading...