Page MenuHomeFreeBSD
Differential D10910

Fix HWPMC interrupt handling in Counting Mode
ClosedPublic
Actions

Authored by mw_semihalf.com on May 25 2017, 3:31 PM.
Tags
Referenced Files
F114218222: D10910.id29563.diff
Wed, Apr 9, 8:23 AM
Unknown Object (File)
Sun, Apr 6, 5:47 AM
Unknown Object (File)
Mon, Mar 31, 8:17 AM
Unknown Object (File)
Tue, Mar 11, 3:17 AM
Unknown Object (File)
Mar 8 2025, 5:34 PM
Unknown Object (File)
Feb 21 2025, 10:28 PM
Unknown Object (File)
Feb 17 2025, 5:35 PM
Unknown Object (File)
Feb 3 2025, 7:38 PM
View All 60 Files
Subscribers
andrew
gnn
imp
mkm_semihalf.com

Details

Reviewers
zbb
loos
arnaud.ysmal_stormshield.eu
fabient
bz
Commits
rS319911: Fix HWPMC interrupt handling in Counting Mode
Summary
  • Fix support for Cycle Counter (evsel == 0xFF)
  • Stop and mask interrupts from all counters on init and finish

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mw_semihalf.com created this revision.May 25 2017, 3:31 PM
Herald added subscribers: gnn, andrew, imp. · View Herald TranscriptMay 25 2017, 3:31 PM
mw_semihalf.com added a parent revision: D10909: Add detection of CPU class for ARMv6/v7.May 25 2017, 3:31 PM
mw_semihalf.com added a child revision: D10911: Fix event table for Cortex A9..
andrew added a reviewer: bz.May 26 2017, 1:16 PM
bz resigned from this revision.May 26 2017, 1:31 PM

The 0xff should probably a #define somewhere but that's unrelated. I think we've done something similar for the timer code in the past; not sure in which review or tree that ended up.

mw_semihalf.com updated this revision to Diff 29321.Jun 8 2017, 2:54 AM

Replace magic number with macro, as pointed by @bz

bz added a comment.Jun 8 2017, 1:17 PM

Thanks for the #define !

Closed by commit rS319911: Fix HWPMC interrupt handling in Counting Mode (authored by zbb). · Explain WhyJun 13 2017, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
41 lines
sys/
1 line

Diff 29321

View Options

sys/dev/hwpmc/hwpmc_armv7.c

Show First 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
FILE *funopen(const void *, FILE *funopen(const void *,
int (* _Nullable)(void *, char *, int), int (* _Nullable)(void *, char *, int),
int (* _Nullable)(void *, const char *, int), int (* _Nullable)(void *, const char *, int),
fpos_t (* _Nullable)(void *, fpos_t, int), fpos_t (* _Nullable)(void *, fpos_t, int),
int (* _Nullable)(void *)); int (* _Nullable)(void *));
#define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0) #define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0)
#define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0) #define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0)
#if __BSD_VISIBLE
typedef __ssize_t cookie_read_function_t(void *, char *, size_t); typedef __ssize_t cookie_read_function_t(void *, char *, size_t);
typedef __ssize_t cookie_write_function_t(void *, const char *, size_t); typedef __ssize_t cookie_write_function_t(void *, const char *, size_t);
typedef int cookie_seek_function_t(void *, off64_t *, int); typedef int cookie_seek_function_t(void *, off64_t *, int);
typedef int cookie_close_function_t(void *); typedef int cookie_close_function_t(void *);
typedef struct { typedef struct {
cookie_read_function_t *read; cookie_read_function_t *read;
cookie_write_function_t *write; cookie_write_function_t *write;
cookie_seek_function_t *seek; cookie_seek_function_t *seek;
cookie_close_function_t *close; cookie_close_function_t *close;
} cookie_io_functions_t; } cookie_io_functions_t;
FILE *fopencookie(void *, const char *, cookie_io_functions_t); FILE *fopencookie(void *, const char *, cookie_io_functions_t);
#endif
/* /*
* Portability hacks. See <sys/types.h>. * Portability hacks. See <sys/types.h>.
*/ */
#ifndef _FTRUNCATE_DECLARED #ifndef _FTRUNCATE_DECLARED
#define _FTRUNCATE_DECLARED #define _FTRUNCATE_DECLARED
int ftruncate(int, __off_t); int ftruncate(int, __off_t);
#endif #endif
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines
View Options

sys/sys/pmc.h

Show First 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
FILE *funopen(const void *, FILE *funopen(const void *,
int (* _Nullable)(void *, char *, int), int (* _Nullable)(void *, char *, int),
int (* _Nullable)(void *, const char *, int), int (* _Nullable)(void *, const char *, int),
fpos_t (* _Nullable)(void *, fpos_t, int), fpos_t (* _Nullable)(void *, fpos_t, int),
int (* _Nullable)(void *)); int (* _Nullable)(void *));
#define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0) #define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0)
#define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0) #define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0)
#if __BSD_VISIBLE
typedef __ssize_t cookie_read_function_t(void *, char *, size_t); typedef __ssize_t cookie_read_function_t(void *, char *, size_t);
typedef __ssize_t cookie_write_function_t(void *, const char *, size_t); typedef __ssize_t cookie_write_function_t(void *, const char *, size_t);
typedef int cookie_seek_function_t(void *, off64_t *, int); typedef int cookie_seek_function_t(void *, off64_t *, int);
typedef int cookie_close_function_t(void *); typedef int cookie_close_function_t(void *);
typedef struct { typedef struct {
cookie_read_function_t *read; cookie_read_function_t *read;
cookie_write_function_t *write; cookie_write_function_t *write;
cookie_seek_function_t *seek; cookie_seek_function_t *seek;
cookie_close_function_t *close; cookie_close_function_t *close;
} cookie_io_functions_t; } cookie_io_functions_t;
FILE *fopencookie(void *, const char *, cookie_io_functions_t); FILE *fopencookie(void *, const char *, cookie_io_functions_t);
#endif
/* /*
* Portability hacks. See <sys/types.h>. * Portability hacks. See <sys/types.h>.
*/ */
#ifndef _FTRUNCATE_DECLARED #ifndef _FTRUNCATE_DECLARED
#define _FTRUNCATE_DECLARED #define _FTRUNCATE_DECLARED
int ftruncate(int, __off_t); int ftruncate(int, __off_t);
#endif #endif
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines