Fix HWPMC interrupt handling in Counting Mode
ClosedPublic
Actions

Authored by mw_semihalf.com on May 25 2017, 3:31 PM.

Tags

Referenced Files

	F147453008: D10910.id29321.diff
	Wed, Mar 11, 3:43 AM

	F147444926: D10910.diff
	Wed, Mar 11, 2:01 AM

	F147417755: D10910.id28800.diff
	Tue, Mar 10, 7:55 PM

	F147397832: D10910.id29563.diff
	Tue, Mar 10, 3:52 PM

	Unknown Object (File)
	Sun, Mar 8, 2:31 AM

	Unknown Object (File)
	Mon, Feb 9, 4:02 PM

	Unknown Object (File)
	Mon, Feb 9, 3:46 PM

	Unknown Object (File)
	Feb 8 2026, 11:49 PM

Subscribers

Details

Reviewers

zbb
loos
arnaud.ysmal_stormshield.eu
fabient
bz

Commits

rS319911: Fix HWPMC interrupt handling in Counting Mode

Summary

Fix support for Cycle Counter (evsel == 0xFF)
Stop and mask interrupts from all counters on init and finish

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mw_semihalf.com created this revision.May 25 2017, 3:31 PM

Herald added subscribers: gnn, andrew, imp. · View Herald TranscriptMay 25 2017, 3:31 PM

mw_semihalf.com added a parent revision: D10909: Add detection of CPU class for ARMv6/v7.May 25 2017, 3:31 PM

mw_semihalf.com added a child revision: D10911: Fix event table for Cortex A9..

andrew added a reviewer: bz.May 26 2017, 1:16 PM

The 0xff should probably a #define somewhere but that's unrelated. I think we've done something similar for the timer code in the past; not sure in which review or tree that ended up.

Replace magic number with macro, as pointed by @bz

Thanks for the #define !

Closed by commit rS319911: Fix HWPMC interrupt handling in Counting Mode (authored by zbb). · Explain WhyJun 13 2017, 6:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hwpmc/

hwpmc_armv7.c

41 lines

sys/

pmc.h

1 line

Diff 29563

View Options

head/sys/dev/hwpmc/hwpmc_armv7.c