Page MenuHomeFreeBSD

Fix HWPMC interrupt handling in Counting Mode
ClosedPublic

Authored by mw_semihalf.com on May 25 2017, 3:31 PM.

Details

Summary
  • Fix support for Cycle Counter (evsel == 0xFF)
  • Stop and mask interrupts from all counters on init and finish

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

andrew added a reviewer: bz.May 26 2017, 1:16 PM
bz resigned from this revision.May 26 2017, 1:31 PM

The 0xff should probably a #define somewhere but that's unrelated. I think we've done something similar for the timer code in the past; not sure in which review or tree that ended up.

Replace magic number with macro, as pointed by @bz

bz added a comment.Jun 8 2017, 1:17 PM

Thanks for the #define !

This revision was automatically updated to reflect the committed changes.