Differential D10556

Update cubic constants
ClosedPublic
Actions

Authored by kmacy on May 1 2017, 2:20 AM.

Details

Reviewers

lstewart

Commits

rS333211: cc_cubic:

Summary

newer cubic drafts change beta from 0.8 to 0.7

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kmacy created this revision.May 1 2017, 2:20 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 1 2017, 2:20 AM

lstewart requested changes to this revision.May 4 2017, 5:06 AM

lstewart added inline comments.

sys/netinet/cc/cc_cubic.h
60	435?
65–66	Need to update this too per section 3.6 of draft.

This revision now requires changes to proceed.May 4 2017, 5:06 AM

Update for comments

sys/netinet/cc/cc_cubic.h
60	Yeah. Not sure where 281 came from.
65–66	I assume you mean 4.6? There is no 3.6.

I updated my primary e-mail. I didn't see your update. Thanks.

lstewart accepted this revision.May 24 2017, 12:25 AM

lstewart added inline comments.

sys/netinet/cc/cc_cubic.h
65–66	Derp. Yes, 4.6.

This revision is now accepted and ready to land.May 24 2017, 12:25 AM

Thanks!

@lstewart our staff transport committer has moved on, would you be willing to commit this to HEAD for Matt?

@shurd @sbruno might one of you commit this?

Closed by commit rS333211: cc_cubic: (authored by sbruno). · Explain WhyMay 3 2018, 3:01 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 3 2018, 3:01 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

cc/

cc_cubic.h

29 lines

Diff 28700

View Options

sys/netinet/cc/cc_cubic.h

Show First 20 Lines • Show All 1,401 Lines • ▼ Show 20 Lines	dointr(unsigned int interval, int reps)
xo_close_container("interrupt-statistics");		xo_close_container("interrupt-statistics");
}		}

static void		static void
domemstat_malloc(void)		domemstat_malloc(void)
{		{
struct memory_type_list *mtlp;		struct memory_type_list *mtlp;
struct memory_type *mtp;		struct memory_type *mtp;
int error, first, i;		size_t i, zones;
		int error, first;

mtlp = memstat_mtl_alloc();		mtlp = memstat_mtl_alloc();
if (mtlp == NULL) {		if (mtlp == NULL) {
xo_warn("memstat_mtl_alloc");		xo_warn("memstat_mtl_alloc");
return;		return;
}		}
if (kd == NULL) {		if (kd == NULL) {
if (memstat_sysctl_malloc(mtlp, 0) < 0) {		if (memstat_sysctl_malloc(mtlp, 0) < 0) {
xo_warnx("memstat_sysctl_malloc: %s",		xo_warnx("memstat_sysctl_malloc: %s",
memstat_strerror(memstat_mtl_geterror(mtlp)));		memstat_strerror(memstat_mtl_geterror(mtlp)));
return;		return;
}		}
		markjUnsubmitted Not Done Inline Actions This won't work if running against a vmcore. markj: This won't work if running against a vmcore.
} else {		} else {
if (memstat_kvm_malloc(mtlp, kd) < 0) {		if (memstat_kvm_malloc(mtlp, kd) < 0) {
error = memstat_mtl_geterror(mtlp);		error = memstat_mtl_geterror(mtlp);
if (error == MEMSTAT_ERROR_KVM)		if (error == MEMSTAT_ERROR_KVM)
xo_warnx("memstat_kvm_malloc: %s",		xo_warnx("memstat_kvm_malloc: %s",
kvm_geterr(kd));		kvm_geterr(kd));
else		else
xo_warnx("memstat_kvm_malloc: %s",		xo_warnx("memstat_kvm_malloc: %s",
memstat_strerror(error));		memstat_strerror(error));
}		}
}		}
xo_open_container("malloc-statistics");		xo_open_container("malloc-statistics");
xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n",		xo_emit("{T:/%13s} {T:/%5s} {T:/%6s} {T:/%7s} {T:/%8s} {T:Size(s)}\n",
"Type", "InUse", "MemUse", "HighUse", "Requests");		"Type", "InUse", "MemUse", "HighUse", "Requests");
xo_open_list("memory");		xo_open_list("memory");
		zones = memstat_malloc_zone_get_count();
for (mtp = memstat_mtl_first(mtlp); mtp != NULL;		for (mtp = memstat_mtl_first(mtlp); mtp != NULL;
mtp = memstat_mtl_next(mtp)) {		mtp = memstat_mtl_next(mtp)) {
if (memstat_get_numallocs(mtp) == 0 &&		if (memstat_get_numallocs(mtp) == 0 &&
memstat_get_count(mtp) == 0)		memstat_get_count(mtp) == 0)
continue;		continue;
xo_open_instance("memory");		xo_open_instance("memory");
xo_emit("{k:type/%13s/%s} {:in-use/%5ju} "		xo_emit("{k:type/%13s/%s} {:in-use/%5ju} "
"{:memory-use/%5ju}{U:K} {:high-use/%7s} "		"{:memory-use/%5ju}{U:K} {:high-use/%7s} "
"{:requests/%8ju} ",		"{:requests/%8ju} ",
memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp),		memstat_get_name(mtp), (uintmax_t)memstat_get_count(mtp),
((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-",		((uintmax_t)memstat_get_bytes(mtp) + 1023) / 1024, "-",
(uintmax_t)memstat_get_numallocs(mtp));		(uintmax_t)memstat_get_numallocs(mtp));
first = 1;		first = 1;
xo_open_list("size");		xo_open_list("size");
for (i = 0; i < 32; i++) {		for (i = 0; i < zones; i++) {
if (memstat_get_sizemask(mtp) & (1 << i)) {		if (memstat_malloc_zone_used(mtp, i)) {
if (!first)		if (!first)
xo_emit(",");		xo_emit(",");
xo_emit("{l:size/%d}", 1 << (i + 4));		xo_emit("{l:size/%d}", memstat_malloc_zone_get_size(i));
first = 0;		first = 0;
}		}
}		}
xo_close_list("size");		xo_close_list("size");
xo_close_instance("memory");		xo_close_instance("memory");
xo_emit("\n");		xo_emit("\n");
}		}
xo_close_list("memory");		xo_close_list("memory");
▲ Show 20 Lines • Show All 242 Lines • Show Last 20 Lines

Update cubic constantsClosedPublicActions