Differential D10556

Update cubic constants
ClosedPublic
Actions

Authored by kmacy on May 1 2017, 2:20 AM.

Details

Reviewers

lstewart

Commits

rS333211: cc_cubic:

Summary

newer cubic drafts change beta from 0.8 to 0.7

Diff Detail

Repository

rS FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kmacy created this revision.May 1 2017, 2:20 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 1 2017, 2:20 AM

lstewart requested changes to this revision.May 4 2017, 5:06 AM

lstewart added inline comments.

sys/netinet/cc/cc_cubic.h
62 ↗	(On Diff #27881)	435?
68 ↗	(On Diff #27881)	Need to update this too per section 3.6 of draft.

This revision now requires changes to proceed.May 4 2017, 5:06 AM

Update for comments

sys/netinet/cc/cc_cubic.h
62 ↗	(On Diff #27881)	Yeah. Not sure where 281 came from.
68 ↗	(On Diff #27881)	I assume you mean 4.6? There is no 3.6.

I updated my primary e-mail. I didn't see your update. Thanks.

lstewart accepted this revision.May 24 2017, 12:25 AM

lstewart added inline comments.

sys/netinet/cc/cc_cubic.h
68 ↗	(On Diff #27881)	Derp. Yes, 4.6.

This revision is now accepted and ready to land.May 24 2017, 12:25 AM

Thanks!

@lstewart our staff transport committer has moved on, would you be willing to commit this to HEAD for Matt?

@shurd @sbruno might one of you commit this?

Closed by commit rS333211: cc_cubic: (authored by sbruno). · Explain WhyMay 3 2018, 3:01 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 3 2018, 3:01 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

cc/

cc_cubic.h

29 lines

Diff 42095

View Options

head/sys/netinet/cc/cc_cubic.h

Update cubic constantsClosedPublicActions