Page MenuHomeFreeBSD
Differential D9894

Honor net.inet.tcp.drop_synfin in other states than LISTEN
ClosedPublic
Actions

Authored by tuexen on Mar 5 2017, 11:08 AM.
Tags
None
Referenced Files
F105525001: D9894.diff
Tue, Dec 17, 6:41 AM
Unknown Object (File)
Mon, Nov 25, 11:03 AM
Unknown Object (File)
Mon, Nov 25, 8:56 AM
Unknown Object (File)
Sun, Nov 24, 7:38 PM
Unknown Object (File)
Sun, Nov 24, 3:59 AM
Unknown Object (File)
Sun, Nov 24, 1:51 AM
Unknown Object (File)
Sat, Nov 23, 6:30 AM
Unknown Object (File)
Fri, Nov 22, 8:42 PM
View All Files
Subscribers
ae
imp
jason_eggnet.com

Details

Reviewers
hiren
rrs
gnn
Group Reviewers
transport
Commits
rS319399: MFC r316743:
rS316743: The sysctl variable net.inet.tcp.drop_synfin is not honored in all states,
Summary

Currently the sysctl variable net.inet.tcp.drop_synfin is not honored in all states, for example not in SYN-SENT.
This patch adds code to check the sysctl variable in other states than LISTEN.

Test Plan

Get all tests from
https://github.com/freebsd-net/tcp-testsuite/blob/master/state-event-engine/rcv-syn-fin-syn-sent/README.md
passed

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 8563
Build 8871: CI src buildJenkins

Event Timeline

tuexen updated this revision to Diff 25996.Mar 5 2017, 11:08 AM
tuexen retitled this revision from to Honor net.inet.tcp.drop_synfin in other states then LISTEN.
tuexen updated this object.
tuexen edited the test plan for this revision. (Show Details)
tuexen added reviewers: gnn, rrs, hiren, transport.
tuexen set the repository for this revision to rS FreeBSD src repository - subversion.
Herald edited edge metadata. · View Herald TranscriptMar 5 2017, 11:08 AM
Herald added a subscriber: imp. · View Herald Transcript
tuexen retitled this revision from Honor net.inet.tcp.drop_synfin in other states then LISTEN to Honor net.inet.tcp.drop_synfin in other states than LISTEN.Mar 5 2017, 11:09 AM
tuexen edited edge metadata.
gnn requested changes to this revision.Mar 30 2017, 1:12 AM

Other than the need for some clarifying parentheses I think this is OK.

sys/netinet/tcp_input.c
1554

I'd like some clarifying parentheses here as well as in all the other similar if statements below.

This revision now requires changes to proceed.Mar 30 2017, 1:12 AM
tuexen updated this revision to Diff 26948.Apr 3 2017, 11:13 AM
tuexen edited edge metadata.

Address gnn's comment by adding parentheses.

Harbormaster failed remote builds in B8451: Diff 26948!Apr 3 2017, 11:18 AM
Harbormaster failed remote builds in B8451: Diff 26948!Apr 3 2017, 11:28 AM
kbowling added a subscriber: jason_eggnet.com.Apr 5 2017, 9:26 AM
ae added a subscriber: ae.Apr 6 2017, 1:47 PM
ae added inline comments.
sys/netinet/tcp_input.c
248

This declaration seems unnecessary. It is already defined at the line 147.

tuexen updated this revision to Diff 27156.Apr 6 2017, 8:57 PM

Address Andrey's comment.

Harbormaster failed remote builds in B8563: Diff 27156!Apr 6 2017, 9:02 PM
gnn accepted this revision.Apr 11 2017, 2:00 PM
This revision is now accepted and ready to land.Apr 11 2017, 2:00 PM
Closed by commit rS316743: The sysctl variable net.inet.tcp.drop_synfin is not honored in all states, (authored by tuexen). · Explain WhyApr 12 2017, 8:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
netinet/
10 lines
tcp_stacks/
38 lines

Diff 27156

View Options

sys/netinet/tcp_input.c

Loading...
View Options

sys/netinet/tcp_stacks/fastpath.c

Loading...