Page MenuHomeFreeBSD

Honor net.inet.tcp.drop_synfin in other states than LISTEN
ClosedPublic

Authored by tuexen on Mar 5 2017, 11:08 AM.
Tags
None
Referenced Files
F105525001: D9894.diff
Tue, Dec 17, 6:41 AM
Unknown Object (File)
Mon, Nov 25, 11:03 AM
Unknown Object (File)
Mon, Nov 25, 8:56 AM
Unknown Object (File)
Sun, Nov 24, 7:38 PM
Unknown Object (File)
Sun, Nov 24, 3:59 AM
Unknown Object (File)
Sun, Nov 24, 1:51 AM
Unknown Object (File)
Sat, Nov 23, 6:30 AM
Unknown Object (File)
Fri, Nov 22, 8:42 PM

Details

Summary

Currently the sysctl variable net.inet.tcp.drop_synfin is not honored in all states, for example not in SYN-SENT.
This patch adds code to check the sysctl variable in other states than LISTEN.

Test Plan

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 7909

Event Timeline

tuexen retitled this revision from to Honor net.inet.tcp.drop_synfin in other states then LISTEN.
tuexen updated this object.
tuexen edited the test plan for this revision. (Show Details)
tuexen added reviewers: gnn, rrs, hiren, transport.
tuexen set the repository for this revision to rS FreeBSD src repository - subversion.
tuexen retitled this revision from Honor net.inet.tcp.drop_synfin in other states then LISTEN to Honor net.inet.tcp.drop_synfin in other states than LISTEN.Mar 5 2017, 11:09 AM
tuexen edited edge metadata.
gnn requested changes to this revision.Mar 30 2017, 1:12 AM

Other than the need for some clarifying parentheses I think this is OK.

sys/netinet/tcp_input.c
1557

I'd like some clarifying parentheses here as well as in all the other similar if statements below.

This revision now requires changes to proceed.Mar 30 2017, 1:12 AM
tuexen edited edge metadata.

Address gnn's comment by adding parentheses.

ae added inline comments.
sys/netinet/tcp_input.c
248

This declaration seems unnecessary. It is already defined at the line 147.

Address Andrey's comment.

This revision is now accepted and ready to land.Apr 11 2017, 2:00 PM
This revision was automatically updated to reflect the committed changes.