Page MenuHomeFreeBSD
Differential D9706

loader: update symlink support in zfs reader
ClosedPublic
Actions

Authored by tsoome on Feb 21 2017, 8:27 PM.
Tags
None
Referenced Files
F81580406: D9706.diff
Thu, Apr 18, 10:51 AM
Unknown Object (File)
Mon, Apr 15, 11:35 PM
Unknown Object (File)
Mon, Apr 15, 11:35 PM
Unknown Object (File)
Mon, Apr 15, 10:57 PM
Unknown Object (File)
Mon, Apr 15, 10:57 PM
Unknown Object (File)
Mon, Apr 15, 10:57 PM
Unknown Object (File)
Mon, Apr 15, 1:40 PM
Unknown Object (File)
Mar 20 2024, 1:20 AM
View All 67 Files
Subscribers
delphij

Details

Reviewers
avg
allanjude
imp
smh
jpaetzel
Commits
rS321525: MFC r314112 (by tsoome): loader: update symlink support in zfs reader
rS314112: loader: update symlink support in zfs reader
Summary

As the current zfs file system is providing symlink via system attributes, need to update the code accordingly.

Test Plan

Tested by browsing and reading different symlinks and by using names like /usr/bin/../lib, bin/.., etc/., etc/./inet, ./bin

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7626
Build 7774: arc lint + arc unit

Event Timeline

tsoome updated this revision to Diff 25494.Feb 21 2017, 8:27 PM
tsoome retitled this revision from to loader: update symlink support in zfs reader.
tsoome updated this object.
tsoome edited the test plan for this revision. (Show Details)
tsoome added reviewers: allanjude, imp.
Herald added a subscriber: delphij. · View Herald TranscriptFeb 21 2017, 8:27 PM
allanjude added reviewers: avg, jpaetzel, smh.Feb 21 2017, 9:03 PM
avg accepted this revision.Feb 22 2017, 8:20 AM
avg edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 22 2017, 8:20 AM
smh requested changes to this revision.Feb 22 2017, 9:31 AM
smh edited edge metadata.
smh added inline comments.
sys/boot/zfs/zfsimpl.c
2273

All of the above are only used in == DMU_OT_SA case so could be moved into that block with char *p;

2294

Does the boot code make use of SET_ERROR, I'm guessing not?

2382

Missing space

This revision now requires changes to proceed.Feb 22 2017, 9:31 AM
tsoome marked 3 inline comments as done.Feb 22 2017, 12:21 PM
tsoome added inline comments.
sys/boot/zfs/zfsimpl.c
2294

no, it does not.

tsoome updated this revision to Diff 25520.Feb 22 2017, 12:22 PM
tsoome edited edge metadata.
tsoome marked an inline comment as done.

Fixes suggested by smh.

smh added inline comments.Feb 22 2017, 12:31 PM
sys/boot/zfs/zfsimpl.c
2282

Just spotted that if you invert the condition you get an arguably cleaner flow e.g.

 else {
    if ((dn->dn_flags & DNODE_FLAG_SPILL_BLKPTR) == 0)
        return (EIO);

    blkptr_t *bp = &dn->dn_spill;

    size = BP_GET_LSIZE(bp);
    ...
}
tsoome updated this revision to Diff 25521.Feb 22 2017, 12:42 PM
tsoome edited edge metadata.

svn update; and clean up the inverted if statement.

tsoome marked an inline comment as done.Feb 22 2017, 12:42 PM
smh accepted this revision.Feb 22 2017, 1:42 PM
smh edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 22 2017, 1:42 PM
allanjude accepted this revision.Feb 22 2017, 2:57 PM
allanjude edited edge metadata.

Approved By: allanjude

Closed by commit rS314112: loader: update symlink support in zfs reader (authored by tsoome). · Explain WhyFeb 22 2017, 10:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
zfs/
204 lines
cddl/
boot/
zfs/
1 line

Diff 25520

View Options

sys/boot/zfs/zfsimpl.c

Loading...
View Options

sys/cddl/boot/zfs/zfsimpl.h

Loading...