Document virtio-console support, based on the information provided in the commit message for r305898 where this feature was added.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 7400
Event Timeline
| bhyve/bhyve.8 | ||
|---|---|---|
| 175 | Done, though that seemed like a common schema to keep these entries short (e.g. see other virtio-* entries above). I pulled the description text from here: https://fedoraproject.org/wiki/Features/VirtioSerial#Summary | |
Comment Actions
I can't really comment on style, but from technical accuracy standpoint it's all good.
Comment Actions
Thanks! As I don't have docs/src bit, either somebody needs to commit that or allow me to commit with the appropriate Approved by: line.
Comment Actions
Having only a doc commit bit myself, I can't approve the src part of the change. You need to find someone with a src bit to approve it. Maybe someone from the other reviewers?
| head/usr.sbin/bhyve/bhyve.8 | ||
|---|---|---|
| 297 ↗ | (On Diff #25754) | Does that sound like a check for igor(1)? As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that? |
| head/usr.sbin/bhyve/bhyve.8 | ||
|---|---|---|
| 297 ↗ | (On Diff #25754) | Hm. It could go in the rarely-used style suggestions (-y). I'll look at that. I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks! |
| head/usr.sbin/bhyve/bhyve.8 | ||
|---|---|---|
| 297 ↗ | (On Diff #25754) | Thanks, I've just committed that. |