Page MenuHomeFreeBSD

bhyve: document virtio-console in the manpage
ClosedPublic

Authored by novel on Feb 13 2017, 2:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 9:25 PM
Unknown Object (File)
Fri, Mar 8, 12:20 AM
Unknown Object (File)
Thu, Mar 7, 11:21 PM
Unknown Object (File)
Feb 17 2024, 2:58 AM
Unknown Object (File)
Dec 20 2023, 3:04 AM
Unknown Object (File)
Jul 3 2023, 9:37 PM
Unknown Object (File)
May 28 2023, 9:15 AM
Unknown Object (File)
May 10 2023, 6:39 AM
Subscribers

Details

Summary

Document virtio-console support, based on the information provided in the commit message for r305898 where this feature was added.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

novel retitled this revision from to bhyve: document virtio-console in the manpage.
novel updated this object.
novel edited the test plan for this revision. (Show Details)
novel set the repository for this revision to rS FreeBSD src repository - subversion.

A few textual upgrades.

bhyve/bhyve.8
281

A maximum of ...

282

s/an/a/

290

remove the "of"

  • Maximum -> A maximum
  • an Unix ... -> a Unix ...
  • remove extra "of"
wblock added inline comments.
bhyve/bhyve.8
175

Very light on details. A one-sentence description of what the virtio-console actually *is* would be helpful here.

296

Avoid contractions: s/There's/There is/
Missing an article: s/use/use the/

novel edited edge metadata.
novel removed rS FreeBSD src repository - subversion as the repository for this revision.
  • Extended virtio-console description, fixed articles, there's -> there is.
novel added inline comments.
bhyve/bhyve.8
175

Done, though that seemed like a common schema to keep these entries short (e.g. see other virtio-* entries above). I pulled the description text from here: https://fedoraproject.org/wiki/Features/VirtioSerial#Summary

jceel edited edge metadata.

I can't really comment on style, but from technical accuracy standpoint it's all good.

This revision is now accepted and ready to land.Feb 23 2017, 12:50 PM
bcr added a reviewer: bcr.

OK from manpages. Make sure to bump the document date.

Thanks! As I don't have docs/src bit, either somebody needs to commit that or allow me to commit with the appropriate Approved by: line.

Having only a doc commit bit myself, I can't approve the src part of the change. You need to find someone with a src bit to approve it. Maybe someone from the other reviewers?

grehan edited edge metadata.
This revision was automatically updated to reflect the committed changes.
head/usr.sbin/bhyve/bhyve.8
297 ↗(On Diff #25754)

Recommend "at present" rather than "as of now".

299 ↗(On Diff #25754)

Likewise, "at present" is simpler and clearer.

head/usr.sbin/bhyve/bhyve.8
297 ↗(On Diff #25754)

Does that sound like a check for igor(1)?

As this bhyve.8 patch is committed already, do you think it's worth to create a follow up patch to fix that?

head/usr.sbin/bhyve/bhyve.8
297 ↗(On Diff #25754)

Hm. It could go in the rarely-used style suggestions (-y). I'll look at that.

I'd say no second patch is needed for this trivial change, and even .Dd does not need a bump. You can do that, or I can if you like. Thanks!

head/usr.sbin/bhyve/bhyve.8
297 ↗(On Diff #25754)

Thanks, I've just committed that.