Page MenuHomeFreeBSD

Don't run dhclient on tap devices when link comes up
AbandonedPublic

Authored by allanjude on Nov 4 2014, 8:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jul 25 2025, 9:56 PM
Unknown Object (File)
Jul 24 2025, 3:43 PM
Unknown Object (File)
Jul 10 2025, 4:38 AM
Unknown Object (File)
Jun 4 2025, 10:43 PM
Unknown Object (File)
May 8 2025, 4:34 PM
Unknown Object (File)
Apr 20 2025, 12:45 PM
Unknown Object (File)
Apr 19 2025, 9:41 AM
Unknown Object (File)
Apr 19 2025, 2:10 AM

Details

Reviewers
gnn
sbruno
Group Reviewers
network
Summary

tap devices are generally used for virtual machines and shouldn't run dhclient
automatically when they get LINK UP

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

allanjude retitled this revision from to Don't run dhclient on tap devices when link comes up.
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)
allanjude added a reviewer: sbruno.
sbruno edited edge metadata.

I cannot think of a case where we would *want* to run dhclient on a tap interface from the host. If nobody comments here this week, I'll approve it.

gnn added a reviewer: gnn.
This revision is now accepted and ready to land.Nov 4 2014, 10:20 PM

Aehm and why not? There are gazillions of other usages, e.g. with VPNs where you might exactly want this. It think it's a hard call on these virtual interfaces, where it's not black or white but gray.

This dhclient script invocation is no-op unless if ifconfig_tap0="DHCP" is defined. I agree that dhclient for tap(4) interface is useless in some cases, but is this script invocation harmful in practice?

While I'm not against the change, but well,
tap is general L2 tunneling mechanism, so it is widely used in various VPN configurations.
Openvpn can be good example: http://www.freebsdwiki.net/index.php/Openvpn_and_dhcp_client (this is server side, but still)

I second on bz, hrs, melifaro. The tap(4) isn't a hypervisor only interface.

Allan:

It appears that this is a non-starter. Want to close/abandon this?