Restructure code slightly to save ip_tos bits earlier.
Fix the bug where the ip_tos field is zeroed out before
assigning to the iptos variable. Restore the ip_tos
and ip_ver fields only if they have been zeroed during
the pseudo-header checksum calculation.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 5333 Build 5518: CI src build Jenkins
Event Timeline
Comment Actions
But take my approval with a huge grain of salt. I don't have any experience in our TCP stack.
Comment Actions
Just a random comment...
sys/netinet/tcp_input.c | ||
---|---|---|
678 | I know we have these splattered all over the tree about 15 times; I keep wondering if I want a macro with a sensible name such as IPV6_GET_TC() or something so that people looking at the code will understand that we get the traffic class there... Maybe in a separate commit to fix them all... |
sys/netinet/tcp_input.c | ||
---|---|---|
678 | For what it's worth, I count a total of 8 instances of this |
head/sys/netinet/tcp_input.c | ||
---|---|---|
726 ↗ | (On Diff #20824) | Can you please explain why this line changed? |
head/sys/netinet/tcp_input.c | ||
---|---|---|
726 ↗ | (On Diff #20824) | Look up 5 lines. len == tlen + off0. |
head/sys/netinet/tcp_input.c | ||
---|---|---|
726 ↗ | (On Diff #20824) | I was avoiding doing the same calculation twice. |