Page MenuHomeFreeBSD
Differential D8003

Document trapcap.
ClosedPublic
Actions

Authored by kib on Sep 22 2016, 10:14 AM.
Tags
Referenced Files
Unknown Object (File)
Sun, Nov 17, 12:29 AM
Unknown Object (File)
Sep 17 2024, 8:29 PM
Unknown Object (File)
Sep 17 2024, 7:47 AM
Unknown Object (File)
Sep 9 2024, 3:58 AM
Unknown Object (File)
Sep 8 2024, 8:05 AM
Unknown Object (File)
Sep 7 2024, 1:56 PM
Unknown Object (File)
Sep 7 2024, 11:29 AM
Unknown Object (File)
Sep 7 2024, 6:57 AM
View All 59 Files
Subscribers
cem
imp
wblock

Details

Reviewers
emaste
cem
oshogbo
Group Reviewers
manpages
Commits
rS306257: Document r306081, i.e. procctl(PROC_TRAPCAP) and sysctl kern.trap_enocap.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 5270
Build 5439: CI src buildJenkins

Event Timeline

kib updated this revision to Diff 20609.Sep 22 2016, 10:14 AM
kib retitled this revision from to Document trapcap..
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added reviewers: emaste, oshogbo.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
kib added a project: manpages.
Herald added a reviewer: manpages. · View Herald TranscriptSep 22 2016, 10:14 AM
Herald added a subscriber: imp. · View Herald Transcript
cem added a subscriber: cem.Sep 22 2016, 5:11 PM
cem added inline comments.
lib/libc/sys/procctl.2
356

might still cause the signal to be delivered; see
.Xr capsicum 4 .

360

s/the signal/signal/

374

s/of the signalling/of signalling/

375

No comma here.

378

No comma here.

384

See the note about sysctl

386

s/independed/independent/
s/of the signal/of signal/

484

s/requests/request/

kib marked 8 inline comments as done.Sep 22 2016, 5:24 PM
kib updated this revision to Diff 20623.Sep 22 2016, 5:27 PM
kib edited edge metadata.

Update diff after cem' notes.

Herald edited edge metadata. · View Herald TranscriptSep 22 2016, 5:27 PM
cem accepted this revision.Sep 22 2016, 5:48 PM
cem added a reviewer: cem.

LGTM modulo the one nit.

lib/libc/sys/procctl.2
384

I would drop "MIB" here. "sysctl kern.trap_enocap" seems pretty clear to me.

This revision is now accepted and ready to land.Sep 22 2016, 5:48 PM
kib updated this revision to Diff 20624.Sep 22 2016, 5:56 PM
kib edited edge metadata.

Remove 'MIB' (two times).

This revision now requires review to proceed.Sep 22 2016, 5:56 PM
cem accepted this revision.Sep 22 2016, 5:58 PM
cem edited edge metadata.
This revision is now accepted and ready to land.Sep 22 2016, 5:58 PM
Closed by commit rS306257: Document r306081, i.e. procctl(PROC_TRAPCAP) and sysctl kern.trap_enocap. (authored by kib). · Explain WhySep 23 2016, 9:26 AM
This revision was automatically updated to reflect the committed changes.
wblock added a subscriber: wblock.Sep 23 2016, 5:28 PM
wblock added inline comments.
head/lib/libc/sys/cap_enter.2
75 ↗(On Diff #20631)

s/set to/set to a/

80 ↗(On Diff #20631)

Comma not needed.

83 ↗(On Diff #20631)

"the" not needed here:

On signal delivery, the
head/lib/libc/sys/procctl.2
331 ↗(On Diff #20631)

Reversing the first two parts makes this clearer:

For the specified processes which are executing in a capability mode sandbox,
enable or disable the synchronous

This is still a very long and complicated sentence and would be better split into two or three shorter sentences.

334 ↗(On Diff #20631)

s/either/either a/

356 ↗(On Diff #20631)

Split sentence instead of using semicolon:

might still cause the signal to be delivered.
See
374 ↗(On Diff #20631)

s/Returns/Return/

kib mentioned this in D8023: Editing for cap_enter(2) and procctl(2)..Sep 24 2016, 7:39 AM
kib marked 7 inline comments as done.

wblock comments are put into the D8023 review.

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
32 lines
65 lines

Diff 20624

View Options

lib/libc/sys/cap_enter.2

Loading...
View Options

lib/libc/sys/procctl.2

Loading...