Page MenuHomeFreeBSD
Differential D7942

compat32 for capsicum
ClosedPublic
Actions

Authored by kib on Sep 18 2016, 1:07 PM.
Tags
None
Referenced Files
F172608596: D7942.id20469.diff
Sat, Sep 19, 4:16 PM
Unknown Object (File)
Fri, Sep 18, 10:10 AM
Unknown Object (File)
Fri, Sep 18, 10:04 AM
Unknown Object (File)
Fri, Sep 18, 9:54 AM
Unknown Object (File)
Fri, Sep 18, 9:36 AM
Unknown Object (File)
Thu, Sep 17, 8:09 AM
Unknown Object (File)
Wed, Sep 16, 5:31 AM
Unknown Object (File)
Sat, Sep 12, 4:44 AM
View All Files
Subscribers
allanjude
imp
oshogbo
pjd

Details

Reviewers
emaste
bapt
Commits
rS305954: Add compat32 support for capsicum.
Test Plan

Tested with elfdump and indexinfo from i386, on amd64.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 5210
Build 5348: CI src buildJenkins

Event Timeline

kib updated this revision to Diff 20450.Sep 18 2016, 1:07 PM
kib retitled this revision from to compat32 for capsicum.
kib updated this object.
kib edited the test plan for this revision. (Show Details)
kib added reviewers: emaste, bapt.
kib set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 1:07 PM
kib updated this revision to Diff 20452.Sep 18 2016, 2:16 PM
kib edited the test plan for this revision. (Show Details)

Bug fixes.

bapt accepted this revision.Sep 18 2016, 2:25 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Sep 18 2016, 2:25 PM
emaste accepted this revision.Sep 18 2016, 2:52 PM
emaste edited edge metadata.
emaste added inline comments.
sys/compat/freebsd32/capabilities.conf
35–36

Can you clarify this comment -- that is, is it that things won't work if this is not kept true, or that it's done for maintainability / keeping the two in sync?

emaste added subscribers: oshogbo, pjd, allanjude.Sep 18 2016, 2:52 PM
kib updated this revision to Diff 20453.Sep 18 2016, 3:14 PM
kib edited edge metadata.

Clarify comment. Reorder copyright notices.

This revision now requires review to proceed.Sep 18 2016, 3:14 PM
emaste accepted this revision.Sep 18 2016, 3:33 PM
emaste edited edge metadata.

For reference this is PR212083. I wish we didn't have the duplication, but I think this is a good step forward.

There is a capsicum unit-test suite at https://github.com/google/capsicum-test that we can try running on top of compat32 at some point.

This revision is now accepted and ready to land.Sep 18 2016, 3:33 PM
Closed by commit rS305954: Add compat32 support for capsicum. (authored by kib). · Explain WhySep 18 2016, 10:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
compat/
freebsd32/
2 lines
284 lines
12 lines
2 lines

Diff 20452

View Options

sys/compat/freebsd32/Makefile

Loading...
View Options

sys/compat/freebsd32/capabilities.conf

Loading...
View Options

sys/compat/freebsd32/freebsd32_capability.c

Loading...
View Options

sys/compat/freebsd32/syscalls.master

Loading...