Page MenuHomeFreeBSD
Differential D7568

Register GICv3 xref
ClosedPublic
Actions

Authored by mst_semihalf.com on Aug 18 2016, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 12:49 PM
Unknown Object (File)
Fri, Dec 6, 4:40 PM
Unknown Object (File)
Nov 24 2024, 2:43 AM
Unknown Object (File)
Nov 12 2024, 6:33 PM
Unknown Object (File)
Oct 29 2024, 2:53 AM
Unknown Object (File)
Oct 4 2024, 2:57 AM
Unknown Object (File)
Oct 2 2024, 10:49 AM
Unknown Object (File)
Sep 30 2024, 9:49 AM
View All 67 Files
Subscribers
andrew
emaste
arm64

Details

Reviewers
zbb
wma
imp
Commits
rS306068: Register GICv3 xref.
Summary

This allows other drivers to retrieve interrupt parent node.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mst_semihalf.com updated this revision to Diff 19464.Aug 18 2016, 6:42 PM
mst_semihalf.com retitled this revision from to Register GICv3 xref.
mst_semihalf.com updated this object.
mst_semihalf.com edited the test plan for this revision. (Show Details)
mst_semihalf.com added reviewers: zbb, imp.
mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mst_semihalf.com added a subscriber: arm64.
Herald added subscribers: emaste, andrew. · View Herald TranscriptAug 18 2016, 6:42 PM
andrew added a comment.Aug 18 2016, 6:58 PM

Why do you need to retrieve this? It's normally done through INTRNG.

sys/arm64/arm64/gic_v3.c
244 ↗(On Diff #19464)

This line no longer exists, you are on an old copy of the file.

mst_semihalf.com added a child revision: D7579: Support for MSI-X on Annapurna Alpine.Aug 19 2016, 11:38 AM
mst_semihalf.com updated this revision to Diff 19726.Aug 26 2016, 3:54 PM

Updated base file version - no change in added code.

mst_semihalf.com added inline comments.Aug 26 2016, 3:57 PM
sys/arm64/arm64/gic_v3.c
244 ↗(On Diff #19464)

I updated the diff, now it bases on the current version of the file.

mst_semihalf.com added a comment.Aug 26 2016, 3:58 PM
In D7568#157092, @andrew wrote:

Why do you need to retrieve this? It's normally done through INTRNG.

D7579 uses this to retrieve iparent and PIC dev to be able to call PIC_* methods.

zbb added a reviewer: wma.Sep 6 2016, 3:15 PM
zbb accepted this revision.Sep 6 2016, 3:32 PM
zbb edited edge metadata.
zbb added inline comments.
sys/arm64/arm64/gic_v3.c
219 ↗(On Diff #19726)

Shouldn't this be phandle_t?

This revision is now accepted and ready to land.Sep 6 2016, 3:32 PM
andrew added inline comments.Sep 6 2016, 3:53 PM
sys/arm64/arm64/gic_v3.c
219 ↗(On Diff #19726)

phandle_t doesn't exist in ACPI world.

wma edited edge metadata.Sep 7 2016, 5:44 AM

My only concern is if we can move this part of code to another file, like gicv3_fdt, where we have xref stuff already. In the present shape it fails to compile when FDT support is disabled.

mst_semihalf.com updated this revision to Diff 20196.Sep 8 2016, 3:38 PM
mst_semihalf.com edited edge metadata.

Move xref registration to gic_v3_fdt.c

This revision now requires review to proceed.Sep 8 2016, 3:38 PM
mst_semihalf.com added a comment.Sep 8 2016, 3:38 PM
In D7568#162015, @wma wrote:

My only concern is if we can move this part of code to another file, like gicv3_fdt, where we have xref stuff already. In the present shape it fails to compile when FDT support is disabled.

Fixed.

Closed by commit rS306068: Register GICv3 xref. (authored by wma). · Explain WhySep 21 2016, 5:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
3 lines

Diff 20196

View Options

sys/arm64/arm64/gic_v3_fdt.c

Loading...