Validate that commands run successfully, have no duplicates,
sorted where applicable, and the dumped configuration can be consumed
again with the -k option.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78580
Build 75463: arc lint + arc unit

Event Timeline

novel created this revision.Thu, Oct 29, 6:49 PM

Herald added a reviewer: bhyve. · View Herald TranscriptThu, Oct 29, 6:49 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

novel requested review of this revision.Thu, Oct 29, 6:49 PM

Harbormaster completed remote builds in B78500: Diff 190835.Thu, Oct 29, 6:49 PM

novel added a reviewer: tests.Thu, Oct 29, 6:52 PM

My suggestions are mostly being made in the vein of reducing redundant flags, making the code easier to read and maintain.

Also, please add the new test to tools/build/mk/OptionalObsoleteFiles.inc so it gets cleaned up when MK_BHYVE=no.

usr.sbin/bhyve/tests/bhyve_test.sh
9	This helps folks that make install the tests or install a release that contains the tests, then set `MK_BHYVE=no`, run `make delete-old`, and the tests are left behind.
14–15
18
20–22	Here's an alternative method for handling this.
26–27	A lot of these are implied.
35
49–50
61–62
64–65
68–69	This logic should be DRYed with my previous suggestion.
72–73
78–79
95–96
102
107–108
120–129