Paths

Table of Contentst

Differential D60456

x11/bhotkeys: New port
AcceptedPublic
Actions

Authored by dteske on Thu, Oct 8, 4:22 AM.

Tags

None

Referenced Files

	F175287394: D60456.diff
	Fri, Oct 9, 4:56 PM

	F175234402: D60456.id189019.diff
	Fri, Oct 9, 7:45 AM

	F175218684: D60456.id189019.diff
	Fri, Oct 9, 4:57 AM

	F175196387: D60456.diff
	Fri, Oct 9, 12:46 AM

	Unknown Object (File)
	Thu, Oct 8, 11:07 PM

	Unknown Object (File)
	Thu, Oct 8, 6:44 AM

	Unknown Object (File)
	Thu, Oct 8, 6:42 AM

	Unknown Object (File)
	Thu, Oct 8, 6:34 AM

Subscribers

None

Details

Reviewers

fuz
jrm
adrian
emaste

Summary

Grab-proof X11 hotkey listener. Plugins are separate ports.
The package ships the listener, the recovery panel, session
start, and the greeter helper.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77833
Build 74716: arc lint + arc unit

Event Timeline

dteske requested review of this revision.Thu, Oct 8, 4:22 AM

dteske created this revision.

Harbormaster completed remote builds in B77833: Diff 189019.Thu, Oct 8, 4:22 AM

dteske added a child revision: D60457: x11/bhotkeys-airplane: New port.Thu, Oct 8, 5:10 AM

dteske added a child revision: D60458: x11/bhotkeys-albert: New port.Thu, Oct 8, 5:16 AM

dteske added a child revision: D60459: x11/bhotkeys-audio: New port.Thu, Oct 8, 7:04 PM

Very minor, optional nit:

The Committer's Guide says, in the commit message, the first letter of the subject should be capitalized. If you wanted to conform to that, it would be x11/bhotkeys: New port.

x11/bhotkeys/Makefile
11	AFAICT `USES=localbase:ldflags` has no effect here. The upstream Makefile gets `-I/usr/local/include` and `-L/usr/local/lib` through `USES=pkgconfig`.

jrm mentioned this in D60457: x11/bhotkeys-airplane: New port.Fri, Oct 9, 1:49 AM

jrm mentioned this in D60458: x11/bhotkeys-albert: New port.

jrm mentioned this in D60459: x11/bhotkeys-audio: New port.Fri, Oct 9, 1:58 AM

dteske added a child revision: D60490: x11/bhotkeys-brightness: New port.Fri, Oct 9, 2:17 AM

dteske retitled this revision from x11/bhotkeys: new port to x11/bhotkeys: New port.Fri, Oct 9, 2:47 AM

dteske added a child revision: D60492: x11/bhotkeys-display-common: New port.Fri, Oct 9, 2:59 AM

dteske added a child revision: D60494: x11/bhotkeys-gnome: New port.Fri, Oct 9, 3:15 AM

dteske added a child revision: D60495: x11/bhotkeys-i3: New port.Fri, Oct 9, 4:32 AM

dteske added a child revision: D60496: x11/bhotkeys-kde: New port.Fri, Oct 9, 4:36 AM

dteske added a child revision: D60497: x11/bhotkeys-lid-state: New port.Fri, Oct 9, 4:39 AM

dteske added a child revision: D60498: x11/bhotkeys-lock: New port.Fri, Oct 9, 4:46 AM

dteske added a child revision: D60499: x11/bhotkeys-mate: New port.Fri, Oct 9, 4:49 AM

dteske added a child revision: D60500: x11/bhotkeys-media: New port.Fri, Oct 9, 5:04 AM

Remove useless USES=localbase:ldflags (jrm)

Harbormaster completed remote builds in B77885: Diff 189163.Fri, Oct 9, 5:08 AM

dteske marked an inline comment as done.Fri, Oct 9, 5:08 AM

dteske added inline comments.

x11/bhotkeys/Makefile
11	Confirmed and removed

dteske added a child revision: D60508: x11/bhotkeys-xfce: New port.Fri, Oct 9, 9:01 AM

dteske added a child revision: D60511: x11/framework-autorotate-hotkey: New port.Fri, Oct 9, 9:21 AM

jrm accepted this revision.Fri, Oct 9, 3:52 PM

This revision is now accepted and ready to land.Fri, Oct 9, 3:52 PM

Revision Contents
Changeset List

Path

Size

x11/

1 line

bhotkeys/

27 lines

3 lines

5 lines

39 lines

Diff 189019

x11/Makefile

Loading...

x11/bhotkeys/Makefile

Loading...

x11/bhotkeys/distinfo

Loading...

x11/bhotkeys/pkg-descr

Loading...

x11/bhotkeys/pkg-plist

Loading...