vmm: release the lock when vrtc_snapshot() fails
AcceptedPublic
Actions

Authored by wanpengqian_gmail.com on Fri, Oct 2, 8:19 AM.

Details

Reviewers

jhb
markj
bnovkov

Group Reviewers

bhyve

Summary

The error path of the SNAPSHOT_*_OR_LEAVE() macros jumped past
VRTC_UNLOCK() and returned with the vrtc lock held.

Signed-off-by: Wanpeng Qian <wanpengqian@gmail.com>
Sponsored by: keelos.dev

Test Plan

By inspection. Compile-tested on main (f958aa7e7); the error path is not taken in normal use (it needs a snapshot buffer that is too small).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77607
Build 74490: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com created this revision.Fri, Oct 2, 8:19 AM

wanpengqian_gmail.com held this revision as a draft.

Herald added a reviewer: bhyve. · View Herald TranscriptFri, Oct 2, 8:19 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

Harbormaster completed remote builds in B77607: Diff 188374.Fri, Oct 2, 8:19 AM

wanpengqian_gmail.com edited the test plan for this revision. (Show Details)Fri, Oct 2, 8:19 AM

wanpengqian_gmail.com added a child revision: D60233: vmm: do not let the RTC's periodic interrupt drift.

wanpengqian_gmail.com published this revision for review.Fri, Oct 2, 10:48 AM

wanpengqian_gmail.com added reviewers: jhb, markj.

bnovkov accepted this revision.Fri, Oct 2, 12:36 PM

This revision is now accepted and ready to land.Fri, Oct 2, 12:36 PM

markj accepted this revision.Fri, Oct 2, 3:48 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

io/

vrtc.c

3 lines

Diff 188374

View Options

vmm: release the lock when vrtc_snapshot() failsAcceptedPublicActions