virtio_console: Negotiate VIRTIO_CONSOLE_F_SIZE
AcceptedPublic
Actions

Authored by kfv on Mon, Sep 28, 10:41 AM.

Tags

None

Referenced Files

	F174413609: D60089.diff
	Sat, Oct 3, 12:43 AM

	F174355493: D60089.id187867.diff
	Fri, Oct 2, 3:46 PM

	Unknown Object (File)
	Thu, Oct 1, 9:30 PM

	Unknown Object (File)
	Thu, Oct 1, 9:03 PM

	Unknown Object (File)
	Thu, Oct 1, 3:59 AM

	Unknown Object (File)
	Wed, Sep 30, 8:28 PM

	Unknown Object (File)
	Wed, Sep 30, 4:41 AM

	Unknown Object (File)
	Tue, Sep 29, 3:22 PM

View All 12 Files

Subscribers

None

Details

Reviewers

dteske
fuz
adrian
bryanv
imp
markj

Summary

The driver reads cols/rows and sets the tty window size but
never offered the feature, so that code has been dead since
the very beginning; also read size under the configuration
generation count.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77408
Build 74291: arc lint + arc unit

Event Timeline

kfv requested review of this revision.Mon, Sep 28, 10:41 AM

kfv created this revision.

Harbormaster completed remote builds in B77408: Diff 187867.Mon, Sep 28, 10:41 AM

kfv added a child revision: D60094: virtio_console: Handle VIRTIO_CONSOLE_RESIZE.Mon, Sep 28, 12:22 PM

markj accepted this revision.Mon, Sep 28, 8:20 PM

This revision is now accepted and ready to land.Mon, Sep 28, 8:20 PM

kfv retitled this revision from virtio: Negotiate VIRTIO_CONSOLE_F_SIZE to virtio_console: Negotiate VIRTIO_CONSOLE_F_SIZE.Wed, Sep 30, 9:13 AM

Approved for commit.
Unfortunately this is outside of my area of expertise, so I can't really review the code.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

console/

virtio_console.c

17 lines

Diff 187867

View Options

sys/dev/virtio/console/virtio_console.c

virtio_console: Negotiate VIRTIO_CONSOLE_F_SIZEAcceptedPublicActions