libfetch: Plug leak in 304 Not Modified case
ClosedPublic
Actions

Authored by des on Fri, Sep 25, 10:38 AM.

Tags

None

Referenced Files

	F174681900: D60016.diff
	Mon, Oct 5, 4:06 AM

	F174662174: D60016.id.diff
	Mon, Oct 5, 1:10 AM

	Unknown Object (File)
	Sun, Oct 4, 1:06 AM

	Unknown Object (File)
	Sat, Oct 3, 9:00 PM

	Unknown Object (File)
	Sat, Oct 3, 2:24 AM

	Unknown Object (File)
	Fri, Oct 2, 11:53 AM

	Unknown Object (File)
	Fri, Oct 2, 8:30 AM

	Unknown Object (File)
	Fri, Oct 2, 2:34 AM

View All 25 Files

Subscribers

imp

Details

Reviewers

markj

Commits

rGb212f565fb1a: libfetch: Plug leak in 304 Not Modified case

Summary

When we get a 304 Not Modified response, we need to go through the error
path to properly free any resources we've allocated instead of just
returning NULL directly.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77310
Build 74193: arc lint + arc unit

Event Timeline

des created this revision.Fri, Sep 25, 10:38 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 25, 10:38 AM

des requested review of this revision.Fri, Sep 25, 10:38 AM

Harbormaster completed remote builds in B77310: Diff 187659.Fri, Sep 25, 10:38 AM

des added a parent revision: D60015: libfetch: Correctly free redirect target.Fri, Sep 25, 10:38 AM

des added a child revision: D60017: libfetch: Plug connection leaks in FTP code.

markj accepted this revision.Wed, Sep 30, 2:58 PM

This revision is now accepted and ready to land.Wed, Sep 30, 2:58 PM

Closed by commit rGb212f565fb1a: libfetch: Plug leak in 304 Not Modified case (authored by des). · Explain WhyWed, Sep 30, 4:56 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGb212f565fb1a: libfetch: Plug leak in 304 Not Modified case.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

http.c

2 lines

Diff 187659

View Options

libfetch: Plug leak in 304 Not Modified caseClosedPublicActions