libfetch: Plug leak in 304 Not Modified case
Needs ReviewPublic
Actions

Authored by des on Fri, Sep 25, 10:38 AM.

Tags

None

Referenced Files

	F173429647: D60016.id.diff
	Fri, Sep 25, 9:36 PM

	F173405133: D60016.id187659.diff
	Fri, Sep 25, 6:14 PM

	F173390384: D60016.diff
	Fri, Sep 25, 3:52 PM

	F173386382: D60016.id187659.diff
	Fri, Sep 25, 3:11 PM

	F173386258: D60016.id187659.diff
	Fri, Sep 25, 3:10 PM

	F173380950: D60016.diff
	Fri, Sep 25, 2:12 PM

	F173368192: D60016.id187659.diff
	Fri, Sep 25, 12:10 PM

	F173367647: D60016.diff
	Fri, Sep 25, 12:04 PM

Subscribers

imp

Details

Reviewers

markj

Summary

When we get a 304 Not Modified response, we need to go through the error
path to properly free any resources we've allocated instead of just
returning NULL directly.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77310
Build 74193: arc lint + arc unit

Event Timeline

des created this revision.Fri, Sep 25, 10:38 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 25, 10:38 AM

des requested review of this revision.Fri, Sep 25, 10:38 AM

Harbormaster completed remote builds in B77310: Diff 187659.Fri, Sep 25, 10:38 AM

des added a parent revision: D60015: libfetch: Correctly free redirect target.Fri, Sep 25, 10:38 AM

des added a child revision: D60017: libfetch: Plug connection leaks in FTP code.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

http.c

2 lines

Diff 187659

View Options

libfetch: Plug leak in 304 Not Modified caseNeeds ReviewPublicActions