libfetch: Reject control characters in credentials
Needs ReviewPublic
Actions

Authored by des on Fri, Sep 25, 10:37 AM.

Tags

None

Referenced Files

	F173405897: D60008.id187651.diff
	Fri, Sep 25, 6:21 PM

	F173389384: D60008.diff
	Fri, Sep 25, 3:41 PM

	F173382485: D60008.diff
	Fri, Sep 25, 2:29 PM

	F173382435: D60008.diff
	Fri, Sep 25, 2:28 PM

	F173382318: D60008.id187651.diff
	Fri, Sep 25, 2:27 PM

	F173368455: D60008.id187651.diff
	Fri, Sep 25, 12:13 PM

	F173367892: D60008.diff
	Fri, Sep 25, 12:06 PM

Subscribers

imp

Details

Reviewers

markj

Summary

If a URL contains credentials, check that neither the user name nor the
password contain control characters.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77302
Build 74185: arc lint + arc unit

Event Timeline

des created this revision.Fri, Sep 25, 10:37 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 25, 10:37 AM

des requested review of this revision.Fri, Sep 25, 10:37 AM

Harbormaster completed remote builds in B77302: Diff 187651.Fri, Sep 25, 10:37 AM

des added a parent revision: D60007: libfetch: Limit response line length.Fri, Sep 25, 10:37 AM

des added a child revision: D60015: libfetch: Correctly free redirect target.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

fetch.c

8 lines

Diff 187651

View Options

libfetch: Reject control characters in credentialsNeeds ReviewPublicActions