Differential D60017

libfetch: Plug connection leaks in FTP code
ClosedPublic
Actions

Authored by des on Sep 25 2026, 10:39 AM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

markj

Commits

rG4de70ec0903a: libfetch: Plug connection leaks in FTP code
rG031f3279a0a0: libfetch: Plug connection leaks in FTP code
rG570869838f8b: libfetch: Plug connection leaks in FTP code

Summary

When setting up an FTP transfer, we need to dereference the cached
connection before returning after a failure.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Sep 25 2026, 10:39 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 25 2026, 10:39 AM

des requested review of this revision.Sep 25 2026, 10:39 AM

Harbormaster completed remote builds in B77311: Diff 187660.Sep 25 2026, 10:39 AM

des added a parent revision: D60016: libfetch: Plug leak in 304 Not Modified case.Sep 25 2026, 10:39 AM

markj accepted this revision.Sep 30 2026, 3:09 PM

This revision is now accepted and ready to land.Sep 30 2026, 3:09 PM

Closed by commit rG570869838f8b: libfetch: Plug connection leaks in FTP code. · Explain WhySep 30 2026, 4:56 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG570869838f8b: libfetch: Plug connection leaks in FTP code.

des added a commit: rG031f3279a0a0: libfetch: Plug connection leaks in FTP code.Thu, Nov 5, 3:12 PM

des added a commit: rG4de70ec0903a: libfetch: Plug connection leaks in FTP code.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

ftp.c

10 lines

Diff 188229

View Options

libfetch: Plug connection leaks in FTP codeClosedPublicActions