libfetch: Correctly free redirect target
ClosedPublic
Actions

Authored by des on Fri, Sep 25, 10:38 AM.

Details

Reviewers

Commits

rGcd2fca49d31d: libfetch: Correctly free redirect target

Summary

When processing a redirect, if we get multiple Location headers, we free
the previous one using free(new) instead of fetchFreeURL(new), which
leaks new->doc.

While here, rename new to loc since new is a reserved word in C++.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Fri, Sep 25, 10:38 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 25, 10:38 AM

des requested review of this revision.Fri, Sep 25, 10:38 AM

Harbormaster completed remote builds in B77309: Diff 187658.Fri, Sep 25, 10:38 AM

des added a parent revision: D60008: libfetch: Reject control characters in credentials.Fri, Sep 25, 10:38 AM

des added a child revision: D60016: libfetch: Plug leak in 304 Not Modified case.

markj accepted this revision.Wed, Sep 30, 2:52 PM

This revision is now accepted and ready to land.Wed, Sep 30, 2:52 PM

Closed by commit rGcd2fca49d31d: libfetch: Correctly free redirect target (authored by des). · Explain WhyWed, Sep 30, 4:56 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGcd2fca49d31d: libfetch: Correctly free redirect target.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

http.c

32 lines

Diff 188227

View Options

libfetch: Correctly free redirect targetClosedPublicActions