libfetch: Correctly free redirect target
Needs ReviewPublic
Actions

Authored by des on Fri, Sep 25, 10:38 AM.

Tags

None

Referenced Files

	F173407261: D60015.id187658.diff
	Fri, Sep 25, 6:35 PM

	F173390772: D60015.diff
	Fri, Sep 25, 3:56 PM

	F173383893: D60015.id187658.diff
	Fri, Sep 25, 2:45 PM

	F173381713: D60015.diff
	Fri, Sep 25, 2:21 PM

	F173368453: D60015.id187658.diff
	Fri, Sep 25, 12:13 PM

	F173367795: D60015.diff
	Fri, Sep 25, 12:06 PM

Subscribers

imp

Details

Reviewers

markj

Summary

When processing a redirect, if we get multiple Location headers, we free
the previous one using free(new) instead of fetchFreeURL(new), which
leaks new->doc.

While here, rename new to loc since new is a reserved word in C++.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77309
Build 74192: arc lint + arc unit

Event Timeline

des created this revision.Fri, Sep 25, 10:38 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 25, 10:38 AM

des requested review of this revision.Fri, Sep 25, 10:38 AM

Harbormaster completed remote builds in B77309: Diff 187658.Fri, Sep 25, 10:38 AM

des added a parent revision: D60008: libfetch: Reject control characters in credentials.Fri, Sep 25, 10:38 AM

des added a child revision: D60016: libfetch: Plug leak in 304 Not Modified case.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

http.c

32 lines

Diff 187658

View Options

libfetch: Correctly free redirect targetNeeds ReviewPublicActions